Extra padding needed for paragraphs field-multiple-table th

Created on 29 November 2022, about 2 years ago
Updated 16 January 2023, almost 2 years ago

Extra padding on top of field-multiple-table th needed since RC1

๐Ÿ› Bug report
Status

Closed: cannot reproduce

Component

Code

Created by

๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom danthorne Devon, UK

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • ๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom danthorne Devon, UK

    This is still a thing in RC2. Caused by form-item__label margin-bottom

  • Status changed to Active almost 2 years ago
  • ๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom danthorne Devon, UK
  • Status changed to Needs work almost 2 years ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Harish1688 India

    Hi, read the previous comment regards the issue and find-out the issue padding thing on local. there is 8px margin added in the bottom on ".form-item__label" class, this is a generic class used to labels. for resolving this issue we may add or remove the margin from the bottom. two patches create for both cases we can use according the requirement (in both looks better for me).

    Extra-padding-needed-for-paragraphs-3324308-11.patch
    Extra-padding-needed-for-paragraphs-3324308-12.patch

    Testing Steps:
    1. Install the Drupal 10.0.x version.
    2. Install and set Gin Admin Theme.
    3. create and apply the patch.
    4. Clear the cache and reload the page.

    Testing result: Need review
    Extra padding needed for paragraphs field-multiple-table th

    Moved the issue to Need Review.

  • Status changed to Needs review almost 2 years ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Harish1688 India
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Santosh_Verma

    In my opinion extra padding from top is looking much better instead of removing the bottom one,
    In previous patch #11 source(SCSS) file was missing I have added that file.

    Before

    After

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia djsagar

    It's looks like above issue fixed in gin theme 8.x-3.x-dev.

    Sharing screen short.

  • Status changed to Needs work 11 months ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia djsagar
  • Status changed to RTBC 11 months ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia djsagar

    Removing tag and moving RTBC as it's already verified.

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia pradhumanjainOSL

    pradhumanjain2311 โ†’ made their first commit to this issueโ€™s fork.

  • Status changed to Closed: outdated about 8 hours ago
  • ๐Ÿ‡จ๐Ÿ‡ญSwitzerland saschaeggi Zurich

    Closing as outdated as I wasn't able to reproduce this. We recently pushed some paragraphs related improvements which might have fixed the issue described here, too. If that's not the case please feel free to reopen. Thanks

Production build 0.71.5 2024