Deprecated function addcslashes() warning caused by empty value

Is it related to the Drupal 10 compatibility?
Shall I merge this commit into the Automated Drupal 10 compatibility fixes 📌 Drupal 10 compatibility fixes Fixed MR ?

This fixes the underlying issue by always providing the context information to the render element.

The accessCheck issue is 🐛 Error: Entity queries must explicitly set whether the query should be access checked or not Active and that fix should be handled in the issue that describes that problem. It should NOT be mixed in with this unrelated issue.

Yes, the correct way to fix this error from addcslashes() is to make sure the variables used always have a value.

There are at least five other issues that make many of these same changes surrounding the userCanVote() method. And part of the problem is that the changes in Voting API from D7 to D8, namely the renaming of content_id/content_type to entity_id/entity_type do not seem to be fully reflected in the current Fivestar code.

But if these changes are to be made, they shouldn't be made in isolation - all those other issues need to be looked at and the comments read to ensure this is being changed in the right way and not in a way that we already know doesn't work. Likewise it would be nice to give credit to the people who did the work on those other issues, rather than just throwing away their contributions. In fact IMO it's highly likely that this addcslashes() issue is just a side-effect of an already-known problem and will disappear as a result of fixing those other issues.

Rebased MR on HEAD and changed from content_* to entity_* wording as per #10.

And now with test coverage.

I'm getting nothing but the error on any page that has Fivestar. I'm using the alph4 release, but I don't get which MR or patch I should be using? It's a bit confusing. Thanks

MR 14 (https://git.drupalcode.org/project/fivestar/-/merge_requests/14.patch) should fix the issue.

@heddn Sorry to be a pain. I added the patch and ran this:

@server2:~/newsite$ composer require 'drupal/fivestar:^1.0@alpha'
./composer.json has been updated
Running composer update drupal/fivestar
Gathering patches for root package.
Removing package drupal/fivestar so that it can be re-installed and re-patched.
  - Removing drupal/fivestar (1.0.0-alpha4)
Deleting web/modules/contrib/fivestar - deleted
Loading composer repositories with package information
Updating dependencies
Nothing to modify in lock file
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 1 install, 0 updates, 0 removals
Gathering patches for root package.
Gathering patches for dependencies. This might take a minute.
  - Installing drupal/fivestar (1.0.0-alpha4): Extracting archive
  - Applying patches for drupal/fivestar
    https://git.drupalcode.org/project/fivestar/-/merge_requests/14.patch (#3324052 Deprecated function addcslashes)
   Could not apply patch! Skipping. The error was: Cannot apply patch https://git.drupalcode.org/project/fivestar/-/merge_requests/14.patch
    https://www.drupal.org/files/issues/2023-10-02/fivestar-access-check-3391088-2.patch (#3391088 Entity queries must explicitly set)

My composer.json looks like this in the extra section:

    "extra": {
        "patches": {
            "drupal/fivestar": {
                "#3324052 Deprecated function addcslashes": "https://git.drupalcode.org/project/fivestar/-/merge_requests/14.patch",
                "#3391088 Entity queries must explicitly set": "https://www.drupal.org/files/issues/2023-10-02/fivestar-access-check-3391088-2.patch"
                }
        },

Sometimes I miss the obvious.

Let's just merge this and tag a new release.

https://www.drupal.org/project/fivestar/releases/8.x-1.0-alpha5 →

@heddn when you update the branch like that do we leave the patch in as is, or remove it and just run composer require 'drupal/fivestar:^1.0@alpha'

Normally you would leave the patch file in, but now you can just `composer update` and get alpha5 and remove all patches.

@heddn That did it! No errors, and I can edit the star ratings. You folks are great.

Automatically closed - issue fixed for 2 weeks with no activity.