Fix PHPStan L2 error "Variable $foo in PHPDoc tag @var does not exist. " - Low Hanging Fruit Edition

Converted to an MR and added a few more easy ones. The rest all require a bit more thought, so setting this for a review.

Seems like a good cleanup.

the 3 additions/moves of @var make sense to be added above the variables.

Is there something we can enable in our phpstan config or ignore entries we can remove here to prevent this coming back.

I'm wary of doing these in piecemeal chunks without a corresponding rule change to prevent it coming back - much like the approach we take for PHPCS

I've reviewed the parent issue and see that this was split to achieve some momentum, so in this case I'm ok with committing it, but ideally we'd be adding a rule or updating baselines etc to keep them from coming back.

Committed to 11.x

Thanks folks

larowlan → closed merge request !9751

@larowlan

Is there something we can enable in our phpstan config or ignore entries we can remove here to prevent this coming back.

that would be 📌 Bump PHPStan rule level to 2 Active

Cheers 👍

Automatically closed - issue fixed for 2 weeks with no activity.