- First commit to issue fork.
- Merge request !9059Issue #3320670 "Refactor rest functional resourceTestBase." → (Open) created by ankitv18
- Status changed to Needs review
5 months ago 10:36am 3 August 2024 - Status changed to RTBC
5 months ago 3:13pm 14 August 2024 - Status changed to Needs review
5 months ago 3:35pm 14 August 2024 - 🇬🇧United Kingdom longwave UK
Do we need a separate trait? Can we just say
use ApiRequestTrait { makeApiRequest as request; }
directly in ResourceTestBase?
- 🇺🇸United States smustgrave
Assuming since JsonApi and LinksetController do the same that's why it was done that way.
- 🇮🇳India ankitv18
@longwave Yes we can do that and actually I was planning to do the same but as @smustgrave mentioned I had taken the reference from jsonApi and linksetController.
- 🇮🇳India ankitv18
More simpler without extra trait file
cc: @longwave @smustgrave - Status changed to RTBC
5 months ago 5:51pm 14 August 2024 - 🇺🇸United States smustgrave
Haven't looked but may be worth a novice follow up to see if the other instances in jsonApi and linksetController could be refactored too?
But change here LGTM.
-
longwave →
committed e4d0beac on 11.x
Issue #3320670 by ankitv18, smustgrave, bbrala: Refactor rest\Functional...
-
longwave →
committed e4d0beac on 11.x
- Status changed to Fixed
5 months ago 9:09pm 14 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.