[2.x] Feeds iCal

Good morning @avpaderno. I'd like to re-open this request as there have been a number of recent improvements to the Feeds iCal module, in addition to other contributions I've made in the past few years. Here are some of the recent fixes I've directly written code for:

https://www.drupal.org/project/project_browser/issues/3293909 🐛 Security and maintained icons need to communicate correct information Fixed
https://www.drupal.org/project/feeds_ical/issues/3445551 🐛 PHP 8.2: Creation of dynamic property is deprecated Fixed
https://www.drupal.org/project/feeds_ical/issues/3379345 🐛 Deprecated function in ICal Fixed

Additionally, I am co-maintainer of the following modules:
https://www.drupal.org/project/sfds →
https://www.drupal.org/project/layout_section_fields →

Hoping this additional work is sufficient, but if not I have some features I'm planning for Feeds iCal which I think would provide enough additional PHP code to cover the requirements.

Thanks!
- Ben

Please go through comment #3 & #4.

This project is too small for us and it doesn't contain enough PHP code to really assess your skills as developer.

Thank you @rushikesh-raval
I am planning some feature upgrades for the Feeds iCal module that I will share once they are committed. 'm hopeing these enhancements will provide sufficient PHP code to meet these requirements.

@rushikesh-raval

Following up here, I've added a new Feeds Parser plugin config form to the module in this issue: https://www.drupal.org/project/feeds_ical/issues/3323737 ✨ Feeds Ical module doesn't have functionality to import events before/after specific time period. Active

In addition other small fixes over last few weeks.

I'm hoping this new code gets this closer to where it needs to be for coverage. Additionally, as another potential source of reviewable code, I'm wondering if adding some automated unit and functional tests might suffice?

Noting also that from the comments #3 and #4 that I have been the only regular committer over the last few years.

Thank you!

src/Feeds/Parser/IcalParser.php

    catch (\Exception $e) {
      \Drupal::logger('feeds_ical')->error($e);
    }

The $message parameter passed to the LoggerInterface methods must be a literal string that uses placeholders. It's not a translatable string returned from t() or $this->t(), a string concatenation, or a value returned from a method/function.

Any dependency must be injected in the class constructor.

1. 2.x-dev is a wrong name for a branch. Release branch names always end with the literal .x as described in Release branches → .

2. FILE: feeds_ical.info.yml

core_version_requirement: ^8 || ^9 || ^10

The Drupal Core versions before 8.7.7 do not recognize the core_version_requirement → key.