- Issue created by @ryanrobinson_wlu
- Assigned to ben.hamelin
- πΊπΈUnited States ben.hamelin Adirondack Mountains, NY
Thanks @ryanrobinson_wlu! This was at least partially introduced in 2.2.0 with the "Add additionalProperties to IcalParser" fix.
I've added the missing properties you identified, as well as an exception to the additionalProperties logic to hopefully avoid these moving forward.I also looked at the docs for " #[AllowDynamicProperties]" in https://php.watch/versions/8.2/dynamic-properties-deprecated but that just feels like hiding a potential issue.
- π¨π¦Canada ryanrobinson_wlu
Thank you! The bit I looked into #[AllowDynamicProperties] I got the same impression: maybe there are some situations where it is necessary, but the proper solution usually is to declare the properties.
- Status changed to RTBC
6 months ago 3:16pm 8 May 2024 - Merge request !9Fix for Creation of dynamic property is deprecated β (Merged) created by ben.hamelin
- πΊπΈUnited States ben.hamelin Adirondack Mountains, NY
Can you take a look at the MR? If this fix works for you I'll merge it in and tag 2.2.1 as the latest release.
Thanks! - π¨π¦Canada ryanrobinson_wlu
The changes work in my tests, no more deprecation warnings in the logs.
- Status changed to Fixed
6 months ago 7:17pm 8 May 2024 Automatically closed - issue fixed for 2 weeks with no activity.