Contrib.social

Fix the issues reported by phpcs

Open on Drupal.org ā†’
Created on 1 November 2022, about 2 years ago
Updated 21 August 2024, 3 months ago

Running phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig ./ in the directory containing the module files shows the following warnings/errors.

FILE: ./privacy_docs_world_map_1.0.x/privacy_docs_world_map.module
 82 | WARNING | Only string literals should be passed to t() where possible

FILE: ./privacy_docs_world_map_1.0.x/style/jqvmap.css
  1 | ERROR | [x] Selectors must be on a single line
  2 | ERROR | [x] Blank lines are not allowed between class names
  2 | ERROR | [x] Expected 1 space before opening brace of class definition; newline found
  3 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  3 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
  4 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  4 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
  5 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  5 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
  6 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  6 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
  7 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  7 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
  8 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  8 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
  9 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 10 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 10 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 11 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 11 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 12 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 13 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
 16 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
 20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 27 | ERROR | [x] Multiple selectors should each be on a single line
 28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 33 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 34 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 37 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 39 | ERROR | [x] Selectors must be on a single line
 40 | ERROR | [x] Blank lines are not allowed between class names
 40 | ERROR | [x] Expected 1 space before opening brace of class definition; newline found
 43 | ERROR | [x] Selectors must be on a single line
 44 | ERROR | [x] Blank lines are not allowed between class names
 44 | ERROR | [x] Expected 1 space before opening brace of class definition; newline found

FILE: ./privacy_docs_world_map_1.0.x/style/privacy_documents.css
  74 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  74 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
  75 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  75 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
  76 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  76 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
  77 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  77 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
  78 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  78 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
  79 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  79 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
  80 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  80 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
  81 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  81 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
  82 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  82 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
  83 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  83 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
  84 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  84 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
  85 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  85 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
  86 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  86 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
  87 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  87 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
  88 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  88 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
  89 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  89 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
  90 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  90 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
  91 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  91 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
  91 | ERROR | [ ] Style definitions must end with a semicolon
  95 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  95 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
  96 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  96 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
  97 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  97 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
  98 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  98 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
  98 | ERROR | [ ] Style definitions must end with a semicolon
 102 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 102 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 103 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 103 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 104 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 104 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 105 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 105 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 106 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 106 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 107 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 107 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 108 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 108 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 109 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 109 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 110 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 110 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 110 | ERROR | [x] CSS colours must be defined in lowercase; expected #00539f but found #00539F
 114 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 114 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 115 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 115 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 116 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 116 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 117 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 117 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 117 | ERROR | [ ] Style definitions must end with a semicolon
 121 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 121 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 122 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 122 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 123 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 123 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 124 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 124 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 124 | ERROR | [ ] Style definitions must end with a semicolon
 128 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 128 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 129 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 129 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 130 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 130 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 131 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 131 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 131 | ERROR | [ ] Style definitions must end with a semicolon
 135 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 135 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 136 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 136 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 137 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 137 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 138 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 138 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 138 | ERROR | [ ] Style definitions must end with a semicolon
 142 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 142 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 143 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 143 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 144 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 144 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 145 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 145 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 145 | ERROR | [ ] Style definitions must end with a semicolon
 149 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 149 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 150 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 150 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 151 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 151 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 152 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 152 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 152 | ERROR | [ ] Style definitions must end with a semicolon
 156 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 156 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 157 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 157 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 158 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 158 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 159 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 159 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 159 | ERROR | [ ] Style definitions must end with a semicolon
 163 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 163 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 164 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 164 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 165 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 165 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 166 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 166 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 166 | ERROR | [ ] Style definitions must end with a semicolon
 170 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 170 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 171 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 171 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 172 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 172 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 173 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 173 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 173 | ERROR | [ ] Style definitions must end with a semicolon
 177 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 177 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 178 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 178 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 179 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 179 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 180 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 180 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 180 | ERROR | [ ] Style definitions must end with a semicolon
 184 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 184 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 185 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 185 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 186 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 186 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 187 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 187 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 187 | ERROR | [ ] Style definitions must end with a semicolon
 191 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 191 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 192 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 192 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 193 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 193 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 194 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 194 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 194 | ERROR | [ ] Style definitions must end with a semicolon
 198 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 199 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 202 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 203 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 206 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 206 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 207 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 207 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
 207 | ERROR | [ ] Style definitions must end with a semicolon
 208 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 208 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 210 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 210 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 211 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 211 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
 211 | ERROR | [ ] Style definitions must end with a semicolon
 212 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 212 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 216 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 216 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 217 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 217 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
 217 | ERROR | [ ] Style definitions must end with a semicolon
 218 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 218 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 220 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 220 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 221 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 221 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
 221 | ERROR | [ ] Style definitions must end with a semicolon
 222 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 222 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 223 | ERROR | [x] Expected 1 newline at end of file; 2 found
 224 | ERROR | [x] Additional whitespace found at end of file

FILE: ./privacy_docs_world_map_1.0.x/script/jquery.vmap.js
   50 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
  118 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
  129 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
  268 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
  273 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
  316 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
  316 | ERROR | [x] Expected 1 space before opening brace; found 0
  355 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
  356 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
  360 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
  361 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
  568 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
  568 | ERROR | [x] Expected 1 space before opening brace; found 0
  571 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
  571 | ERROR | [x] Expected 1 space before opening brace; found 0
  599 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
  599 | ERROR | [x] Expected 1 space before opening brace; found 0
  608 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
  608 | ERROR | [x] Expected 1 space before opening brace; found 0
  611 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
  611 | ERROR | [x] Expected 1 space before opening brace; found 0
  633 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
  638 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
  642 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
  643 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
  664 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
  672 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
  676 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
  680 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
  684 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
  688 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
  691 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
  699 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
  700 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
  703 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
  734 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
  797 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
  797 | ERROR | [x] Expected 1 space before opening brace; found 0
  805 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
  805 | ERROR | [x] Expected 1 space before opening brace; found 0
  818 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
  818 | ERROR | [x] Expected 1 space before opening brace; found 0
  834 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
  835 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
  835 | ERROR | [x] Expected 1 space before opening brace; found 0
  844 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
  844 | ERROR | [x] Expected 1 space before opening brace; found 0
  847 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
  847 | ERROR | [x] Expected 1 space before opening brace; found 0
  871 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
  876 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
  876 | ERROR | [x] Expected 1 space before opening brace; found 0
 1092 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
 1106 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
 1129 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 1133 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 1144 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"

FILE: ./privacy_docs_world_map_1.0.x/script/privacy_documents.js
  2 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
  3 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
  4 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
 15 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 16 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 20 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
 21 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 22 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 23 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 24 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 24 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 25 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 26 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 26 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 27 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 27 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
 28 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 29 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 30 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 30 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
 31 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 31 | ERROR | [x] Expected 1 space after ":"; 0 found
 32 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 33 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 34 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 35 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 36 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 37 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 38 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 40 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 41 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 42 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 43 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 44 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 45 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 46 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 47 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 48 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 49 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 52 | ERROR | [x] Whitespace found at end of line
 53 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 53 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
 53 | ERROR | [x] Expected 1 space before opening brace; found 0
 55 | ERROR | [x] Expected 1 space after "/"; 0 found
 63 | ERROR | [x] Whitespace found at end of line
 65 | ERROR | [x] Expected 1 space before "+"; 0 found
 65 | ERROR | [x] Expected 1 space after "+"; 0 found

FILE: ./privacy_docs_world_map_1.0.x/script/maps/jquery.vmap.world.js
 1 | WARNING | File appears to be minified and cannot be processed

FILE: ./privacy_docs_world_map_1.0.x/script/jquery.vmap.min.js
 1 | WARNING | File appears to be minified and cannot be processed

FILE: ./privacy_docs_world_map_1.0.x/script/node_edit.js
 2 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 2 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
 7 | ERROR | [x] Expected 1 newline at end of file; 0 found

FILE: ./privacy_docs_world_map_1.0.x/privacy_docs_world_map.info.yml
 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
 8 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"

FILE: ./privacy_docs_world_map_1.0.x/src/Form/WorldMapConfigSettingsForm.php
 66 | WARNING | Possible useless method overriding detected

FILE: ./privacy_docs_world_map_1.0.x/src/Controller/LoadDocumentsDataController.php
 32 | WARNING | Unused variable $key.

Those warnings/errors need to be fixed, when possible.

šŸ“Œ Task
Status

Needs work

Version

1.0

Component

Code

Created by

šŸ‡®šŸ‡³India vipul tulse

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
    +      $form_state->setErrorByName('field_select_country_state', $message,
               [
                 ':country' => $country_code,
                 ':home_url' => $url,
                 ':nid' => $nid,
               ]
-       ));
+      );

    The lines that follow the changed line are wrongly indented and needs to be changed too.

  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹

    The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.

  • First commit to issue fork.
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡³India bharath-kondeti Hyderabad

    Command used to find phpcs issues: /phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/contrib/privacy_docs_world_map/

    Attached an updated patch addressing #12

  • Merge request !1Issue#3318479 :Adderssed PHP CS issues ā†’ (Open) created by Unnamed author
  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹

    @bharath-kondeti The used command must be reported in the issue summary, not in a comment.

  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹

    Furthermore, either the phpcs report is not complete, or the patch is changing files that should not be changed. It seems the first one.

  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
  • Status changed to Needs work 3 months ago
  • Comment 3 months ago ā†’
    a.aaronjake

    Hi @everyone,

    Applied the patch provided on the comment #15, it was applied smoothly but there are still errors reported. Please see below:

    āžœ  privacy_docs_world_map git:(1.0.x) curl https://www.drupal.org/files/issues/2023-05-08/3318479-14-fix-cs-errors.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 21449  100 21449    0     0  54597      0 --:--:-- --:--:-- --:--:-- 56296
patching file privacy_docs_world_map.info.yml
patching file privacy_docs_world_map.module
patching file script/node_edit.js
patching file script/privacy_documents.js
patching file src/Controller/LoadDocumentsDataController.php
patching file src/Form/WorldMapConfigSettingsForm.php
patching file style/jqvmap.css
patching file style/privacy_documents.css
patching file templates/privacy_docs_world_map_block.html.twig
āžœ  privacy_docs_world_map git:(1.0.x) āœ— ..
āžœ  contrib git:(master) āœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig privacy_docs_world_map

FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/privacy_docs_world_map/privacy_docs_world_map.module
----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Routing\RouteMatchInterface.
----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/privacy_docs_world_map/src/Plugin/Block/PrivacyDoucmentsWorldMapBlock.php
-----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------------
 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigFactoryInterface.
-----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/privacy_docs_world_map/src/Controller/LoadDocumentsDataController.php
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Controller\ControllerBase.
-------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------

Time: 209ms; Memory: 10MB

    Kindly check

    Thanks,
    Jake

  • Comment 3 months ago ā†’
    šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹

    avpaderno ā†’ changed the visibility of the branch 3318479-fix-the-issues to hidden.

  • Pipeline finished with Failed
    3 months ago
    Total: 47s
    #259997
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024