Fix the issues reported by phpcs

Hi, @rohit Patch applied but still getting these issues.

FILE: /smart_title/smart_title.module
--------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR
--------------------------------------------------------------------------------------------------------------------------------
78 | ERROR | [x] list(...) is forbidden, use [...] instead.
---------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------

FILE: /smart_title/smart_title.install
---------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------
32 | ERROR | [x] list(...) is forbidden, use [...] instead.
---------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------

Please review the !1 MR for all of the issues listed above and those that remain.

 /**
- * SmartTitleConfigForm.
+ * Configure smart title settings.
  */

The verb needs to use the Simple Present tense and the third person singular.

-  // @TODO: (add alter || convert to config) && validate.
+  // @todo (add alter || convert to config) && validate.

That needs to be changed in a sentence too.

  * @return string[][]|string[]|string
  *   An array of smart title default setting values or the value of the
  *   specificed option.
- *
- * @TODO
  */

That is probably a call for the maintainers, since they know if the code of that method is complete or there is something that needs to be changed or added.

The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.

Thank you for your feedback, MR and issue description updated.
Please review.

I'm skipping this issue for now.
/smart_title/smart_title.module
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
222 | WARNING | '@todo' should match the format '@todo Fix problem X here.'
--------------------------------------------------------------------------------

Providing Patch with fixes of Drupal, DrupalPractice
Thanku

The last patch is not correct, as it does not fix what reported in previous comments. The MR is correct, for what I can see.

The status change is for what committed in the MR.

I hope you don't mind if I also fix the spelling issues here.

Let's see what the CI process says... Should be all green.

Thank you all!

Automatically closed - issue fixed for 2 weeks with no activity.