- @vimal_nadar opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 3:53pm 30 April 2023 - Status changed to RTBC
over 1 year ago 8:10am 1 June 2023 Verified the MR1 and readme.md file is added. Added screenshot for reference. RTBC++
- Status changed to Needs work
over 1 year ago 8:18am 1 June 2023 - Assigned to nitin_lama
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 10:04am 1 June 2023 - Status changed to Needs work
over 1 year ago 5:05pm 5 June 2023 - 🇳🇴Norway gisle Norway
The README.md in the MR differs from the canonical format as documented here:
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... →For instance don't use all CAPS for "Table of contents" . Don't have a heading above the introduction.
- First commit to issue fork.
- Status changed to Needs review
over 1 year ago 6:53pm 5 June 2023 - Status changed to Needs work
over 1 year ago 7:30pm 5 June 2023 - 🇳🇴Norway gisle Norway
Looks like the Table of contents has ended up after the Introduction.
- Status changed to Needs review
over 1 year ago 7:47pm 5 June 2023 - Status changed to Needs work
over 1 year ago 11:28am 6 June 2023 - 🇳🇴Norway gisle Norway
In the latest instalment, the Table of contents is still inserted after the first section, and there is still a non-standard "##Introduction" header.
Please use the canonical format as documented here:
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... → - Status changed to Needs review
over 1 year ago 11:29am 6 June 2023 - 🇵ðŸ‡Philippines paraderojether
Hi
I reviewed MR!1, I applied against PDF 8.x-1.x-dev with Drupal core version 9.5.9 and confirmed the README.md is added correctly.
I added screenshots for reference.
Thank You. - Status changed to RTBC
over 1 year ago 2:02am 7 June 2023 - Status changed to Needs work
over 1 year ago 5:20am 7 June 2023 - 🇳🇴Norway gisle Norway
The format is still not correct. There should not be any heading "##Introduction".
- Assigned to nitin_lama
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 6:21am 7 June 2023 - Status changed to RTBC
over 1 year ago 11:22am 7 June 2023 - 🇧🇷Brazil elber Brazil
Hi moving to RTBC readme is following drupal standards.
Error mentioned previously has been fixed and (#17)
- Status changed to Needs work
over 1 year ago 11:43am 7 June 2023 - 🇳🇴Norway gisle Norway
The proposed text contains this sentence:
Download pre-built pdf.js from here and extract is into your Drupal libraries directory (Drupal 8 uses /libraries instead of /sites/all/libraries).
There a multiple problems with stat sentence:
- What location does "here" refer to?
- Drupal 8 is EOL. The README should provide up-to-date instructions for supported versions of Drupal (i.e. Drupal 9 and Drupal 10).