Compatibility with CKEditor5 (default in D10 core)

I modified composer.json to allow drupal/core ^9.4 as it has ckeditor5.
I also remove Drupal 8 from info.yml as D8 doesn't have CKEditor 5 and it is also restricted from being enabled in Drupal core > 9.4.

We will need a 3.0 version of the module as it probably isn't compatible with CKEditor 4 or earlier versions of Drupal

#9/#10 would not apply to core 9.5.2 with CKEditor 5 enabled.

@laura.gates Thank you for the feedback, but what do you mean? Inline responsive images is working for me on D9.5.2 with CKE5, as long as I patch it with the fixes from this issue fork. And the current composer constraint added in #9/#10 seems OK for 9.5.2, no?

@GaëlG I was also using comment #5 patch for the Automated D10 compatibility fixes 📌 Automated Drupal 10 compatibility fixes Fixed . It appears that the MR for this ticket and the D10 readiness ticket are incompatible with one another. When I removed the D10 patch from my composer.json this ticket's MR applied correctly.

Apologies for any confusion!

I merged 📌 Automated Drupal 10 compatibility fixes Fixed in this issue fork: https://git.drupalcode.org/project/inline_responsive_images/-/merge_requ...

Hey guys, this is pretty important right now. entity_embed is still not ready for CKEditor5, so there's no way to apply an image style to an image uploaded via CkEditor5. Editors can resize the images freely, as you can't apply an image style. Also, you can't convert them to webp.

The module webp_extras creates a webp filter that you can apply to the text, which at least converts the images to webp, but we still don't have a way to apply image styles to images uploaded via CKEditor5, I believe (if you have any suggestions please let me know).

Is the attached diff stable and working? If so, can we have a new stable release made for D10 and Ckeditor 5.

The current status is "Needs review", meaning: it's up to the community (you!) to test it and provide feedback. From my point of view, it works, but I'm the one who did it. An external point of view is needed.

If it's OK, please change the status to "Reviewed and tested by the community", so that the maintainers know they can put it into the next release.

For more info on issue statuses, see https://www.drupal.org/docs/develop/issues/fields-and-other-parts-of-an-... →

Patch works fine for responsive images, for CKEditor 5 is the easiest method right now. I was using Entity embed and it was just painfully slow.

works fine, but after selecting the image style, the original/raw image is dissapear on the selection, so I can't select original/raw image again without deleting data-image-style on the source.

https://git.drupalcode.org/project/inline_responsive_images/-/merge_requ... doesn't apply on 10.1.1.

Great work everybody! I will be test this MR. The plan is to release a 3.0 version of the module with CKEditor 5 (and D10) compatibility.

In the MR the CKEditor 4 plugin is still available, but the module has a dependency on ckeditor5. Question for the CKEditor experts: is it possible to ship the module with buth CKEditor 4 and 5 integrations, or should we release a 3.0 version with just CKEditor 5 integration?

#22 and others that have had issues I installed from git:

{
    "name": "drupal/recommended-project",
    "description": "Drupal is an open source content management platform powering millions of websites and applications.",
    "type": "project",
    "license": "GPL-2.0-or-later",
    "repositories": [
        {
            "type": "composer",
            "url": "https://packages.drupal.org/8",
      "exclude": ["drupal/inline_responsive_images"]
        },
        {
            "type": "vcs",
            "url": "https://git.drupalcode.org/issue/inline_responsive_images-3317804.git"
        }
    ],

.....

 "require": {
....
        "drupal/inline_responsive_images": "dev-3317804-compatibility-with-ckeditor5",
....

I can confirm #21, there is no way to undo applied style, also will be nice to apply image drag resize width attribute after generating image style when editor tries to resize image manually.

works fine, but after selecting the image style, the original/raw image is dissapear on the selection, so I can't select original/raw image again without deleting data-image-style on the source.

A potential workaround is to create an image style that displays the original image, but I agree the select should let you revert to its original value.

Is it possible to have a dev release to test for drupal 10 ?

Since ckeditor5 is the primary ckeditor in D10, it seems that this fix is major.

@rei, @prudloff: this module is meant to use an image style to display inline images. In the CKEditor 4 plugin it is not possible not to select an image style, it's only because the UX of CKEditor 5 has changed that we cannot easily require selecting an image style. Maybe in a feature request we could have a look at improving this.

This issue has now been merged to the 3.x branch. Thanks for the work GaëlG, jkamizato, jrglasgow, prudloff, Wim Leers and others!

Automatically closed - issue fixed for 2 weeks with no activity.