For us drush site-install --existing-config failed with Workbench 1.6, and the supplied patch fixed that.
This now causes sites with the Update Manager module enabled to fail with the error:
UnexpectedValueException: Could not parse version constraint 9^: Invalid version string "9^" in Composer\Semver\VersionParser->parseConstraint()
It would be really helpful to have a fixed release soon.
Rebased to 3.x add committed. Thanks everyone!
jeroen_vreuls → made their first commit to this issue’s fork.
Patch committed, thanks @Piotr Pakulski!
Patch has been committed. Thanks @dennis_meuwissen!
These changes are already present in the 3.x-dev version.
Change was merged. Thanks @jofitz and @dineshkumarbollu!
@tarasiadis: it seems you are expecting a popup to upload the image and set the image style, in CKEditor 5 in doesn't work like that anymore. You upload the image, then click on it in the editor and a floating control appears that allows you to set the image style.
@ravi kant: I set up everything the same as in your video but it works correctly for me. Can you retest using the 3.x-dev version of the module?
@rei, @prudloff: this module is meant to use an image style to display inline images. In the CKEditor 4 plugin it is not possible not to select an image style, it's only because the UX of CKEditor 5 has changed that we cannot easily require selecting an image style. Maybe in a feature request we could have a look at improving this.
This issue has now been merged to the 3.x branch. Thanks for the work GaëlG, jkamizato, jrglasgow, prudloff, Wim Leers and others!
This has been merged in the 3.x branch. Thanks for the work!
jeroen_vreuls → made their first commit to this issue’s fork.
I get the following error when switching from CKEditor 4 to 5:
Drupal\Component\Plugin\Exception\InvalidPluginDefinitionException: The "video_embed_wysiwyg_video_embed" CKEditor 5 plugin definition is configurable, has non-empty default configuration but has no config schema. Config schema is required for validation. in Drupal\ckeditor5\Plugin\CKEditor5PluginDefinition->validateDrupalAspects()
This is because video_embed_wysiwyg.schema.yml has incorrect indenting for the CKEditor 5 plugin part. I fixed this in the MR.
jeroen_vreuls → made their first commit to this issue’s fork.
Great work everybody! I will be test this MR. The plan is to release a 3.0 version of the module with CKEditor 5 (and D10) compatibility.
In the MR the CKEditor 4 plugin is still available, but the module has a dependency on ckeditor5. Question for the CKEditor experts: is it possible to ship the module with buth CKEditor 4 and 5 integrations, or should we release a 3.0 version with just CKEditor 5 integration?
In patch #22 the line $this->getRequest()->query->remove('destination'); is missing which was present in previous patches.
For us this causes an issue in combination with login_redirect_per_role that the redirect set by that module takes precedence and the users_without_tfa_redirect_to_setup setting doesn't work.
The attached patch adds the line back in, which fixes the issue for us.