Billing profile incomplete, when using the cart form buttons

Updated patch with the wording fixes from the MR.

@jsacksick any plans to merge this?

Let's implement the same for 8.x-1.x like we did for Drupal 7 in MR!12.

anybody → changed the visibility of the branch 8.x-1.x to hidden.

Okay, here we go! Setting this back to Needs review for the 8.x-1.x version. The Drupal 7 version has already been reviewed and seems to be used by several people beside us, e.g. @damienmckenna.

Would be super happy to have the 8.x-1.x version tested, for us it's super helpful in terms PayPal doesn't return billing address details.

Nice work! Added a few comments! :)

See 📌 Fix PHPCS Active regarding the unrelated phpcs CI fail.

PHPCS issues are unrelated.

Static patch for 8.x-1.x until this is merged.

grevil → changed the visibility of the branch 3317359-billing-profile-incomplete to hidden.

LGTM! CI failure is related to 📌 Fix PHPCS Active .

While this can be true for some cases, there is no guarantee that the shipping address is the same as the billing address? I believe the right fix is to have PayPal send the information to us (it's a pity this isn't turned on by default).
Also, the patch introduces mixed casing ($billingProfile instead of $billing_profile) (I'd prefer sticking to the casing used in the code currently.

Can we remove the update hook too? Is it sufficient to just check for an empty locality?

if ($billingProfile && $this->configuration['update_billing_profile_shipping_fallback'] && empty($billingProfile?->address?->locality)) {

since we're checking if ($billingProfile) already, there is probably no need for "?>" in $billingProfile?->address. Also, that's a lot of magic getters :p, perhaps we could consider getting the address array first?

@Grevil could you check that, please? :)

Rerolled against latest dev!

Alright, I fixed the remaining issues noted in #28. That should be it now!

Okay ready for review by @jsacksick! Thanks for the final adjustments @Grevil!