- Issue created by @Anybody
- 🇩🇪Germany Anybody Porta Westfalica
Here we go. Would be great to have this fixed as CI currently fails due to this.
I'm unsure how to fix the remaining issues in the annotations, don't want to break the functionality by disallowed notation. Can someone help?
- 🇩🇪Germany Grevil
I'm unsure how to fix the remaining issues in the annotations, don't want to break the functionality by disallowed notation. Can someone help?
CI is passing? So everything seems to be fixed?
- 🇩🇪Germany Anybody Porta Westfalica
My local phpcs is unhappy with the annotations exceeding the lines:
* credit_card_types = { * "amex", "dinersclub", "discover", "jcb", "maestro", "mastercard", "visa", "unionpay" * },
- 🇩🇪Germany Grevil
Ok, I though, you meant the phpcs ignore annotations...
Well, remote CI is perfectly fine with everything else!
- 🇮🇱Israel jsacksick
Why this change? throw new \PaymentGatewayException? Why did we even have phpcs:ignore for these exceptions I'm confused?
- 🇩🇪Germany Anybody Porta Westfalica
@jsacksick PHPCS is complaining that Exceptions should not be translated. But I think these exceptions texts are later used user-facing so I didn't want to remove the translation!
- 🇩🇪Germany Grevil
Sorry, for some reason I thought that would be a PHP level exception (which doesn't make any sense based on the name alone, my apologies) 😅
Reverted my commit, should be all green again.