- π¨π¦Canada RobLoach Earth
Updated the patch to the latest in 3.0.x, and removed the list syntax change as it's unrelated.
- Status changed to Closed: duplicate
4 months ago 7:08pm 28 February 2024 - πΊπΈUnited States SocialNicheGuru
Dupe of β¨ Block content cache 'max-age' for Gtranslate 3.0+ Needs review
- π¨π¦Canada RobLoach Earth
Technically that's a dupe of this one, check the creation dates :) .... Either way I'm happy to have more eyes on fixing caching.
- Status changed to RTBC
4 months ago 3:59pm 29 February 2024 - πΊπ¦Ukraine HitchShock Ukraine
@socialnicheguru Your logic is really interesting.
β¨ Block content cache 'max-age' for Gtranslate 3.0+ Needs review Was created later but you called this one as a duplicate.
It is not ethical to close someone else's task in favor of your own, even though this one was created earlier and already in the status of RTBCReopened this ticket back to RTBC status and closed your one as a duplicate.
- πΊπΈUnited States SocialNicheGuru
this one was for 8.1
that one at the time was for 3.x
That one is actually older for 3.x and that is why I did it. - πΊπ¦Ukraine HitchShock Ukraine
@socialnicheguru
- It doesn't matter that the ticket was for 8.1 first. You were able to add your patch here for 3.x, instead of creating a new ticket (duplicate).
- At the moment this one contains a patch for 3.x too.
- πΊπΈUnited States SocialNicheGuru
My point was that I created the patch in the other issue for 3.x 9 months ago. 5 months ago you did the same thin in this issue.
I did it there with a reference to this one because sometimes it is common practice to do patches for different versions in different issues.
There was a clear link to this one which you decided not to follow.
If you like to come in after someone else has done the work and take ownership, that is the way you do business.
I like this module and just want to help.
- Status changed to Needs review
3 months ago 12:25pm 10 April 2024 - π¬π§United Kingdom AndyF
Thanks everyone for the work so far, we also noticed our site caching being impacted.
The cache only needs to be invalidated once the module settings are changed.
Seems then that we ought to add a cache tag! See attached, thanks! (For 3.x)