I found 3 more issues:
1. Version 2.0.0 should be compatible with D10, however it still uses removed methods, for example file_create_url and file_url_transform_relative
2. The block is not changed after changing the config from the backend form, it remains cached.
3. Because the block is cached, it won't be hid when it's configured to.
I think I fixed the first 2 issues in the same PR, can you please check?
https://git.drupalcode.org/project/announcement_modal/-/merge_requests/5
leontin → created an issue.
Hi all,
I submitted a PR that mitigates the issue, can you have a look on it?
I try to load the raw config using the language the email needs and from that I build an easy email type entity to use moving forward.
If the language is not provided or the config is missing the code runs as before.
leontin → made their first commit to this issue’s fork.
leontin → created an issue.
martygraphie → credited leontin → .
In the current implementation, the SMTP settings are overridden globally within the request context when $this->smtpConfig->setSettingsOverride($config) is called for custom credentials. This override does not automatically reset after each email is sent. Therefore, if multiple emails are sent in a single request, they will all continue to use the overridden credentials unless explicitly reset.
The mail() function in this setup doesn’t independently refresh the SMTP configuration for each message based on the message ID. Instead, it relies on the active configuration within the request scope. So, without a manual reset to the default settings after each email, any additional emails sent within the same request will retain the credentials from the first override.
To prevent this unintended persistence, we’d need to explicitly reset the SMTP configuration to its defaults after each email or apply a different instance-based configuration that isolates credentials per email.
Please test and let me know how it went.
leontin → created an issue.
leontin → made their first commit to this issue’s fork.
Project page: https://www.drupal.org/project/commerce_euplatesc →
It seems like there was another problem.
Fixed it by unlocking the order when the payment failed.
leontin → created an issue.
Any update on this?
Also added the "url" cache context.
Paid versions that want to change the language prefix always have the cached version on each page.
leontin → made their first commit to this issue’s fork.
leontin → made their first commit to this issue’s fork.
leontin → made their first commit to this issue’s fork.
leontin → created an issue.
leontin → created an issue.
Attaching a patch for both js files.
leontin → created an issue.
leontin → created an issue.
leontin → created an issue.
Re-rolled #11 for D10 compatibility.
leontin → created an issue.
leontin → made their first commit to this issue’s fork.
leontin → made their first commit to this issue’s fork.
leontin → made their first commit to this issue’s fork.
leontin → created an issue.
You are right, I probably was using an older version.
Sorry, the issue can be closed.
Thanks.
leontin → created an issue.
leontin → made their first commit to this issue’s fork.
leontin → made their first commit to this issue’s fork.
leontin → created an issue.
leontin → made their first commit to this issue’s fork.
leontin → made their first commit to this issue’s fork.
leontin → made their first commit to this issue’s fork.