CKEditor5 compatibility

Hi,

I can't download it form git (i need a zip file), that's normal ?

Thanks

Hello,

I still have the message :

Unsupported GitLab operation

You have attempted an action in GitLab that Drupal.org does not currently support.

Please see our GitLab documentation for more information.

When i try to download a zip file on the repository.

Can anyone help please ?

@devil2005, this is an open MR to the existing branch, you can just apply it as a patch.

• Take this and save it as a local patch file: https://git.drupalcode.org/project/ckeditor_bs_grid/-/merge_requests/14....
• Add it to composer.json patches for the module
• If it doesn't apply, switch your module to the 2.0.x branch in composer.json first

Thanks @b_sharpe you're the best!

I haven't access to git or composer on this server, i have to install module manually by backoffice :(

@devil2005, you might need to download the module to your computer from the merge request and install it from there.

Yea, I suppose I could merge this as is. The last item is waiting on 🐛 Drupal.ckeditor5.openDialog missing existingValues param Needs work right now, but i'm debating just creating my own function for it and call it done for now.

@trackleft2 : i tried but i can't (see error message)

@b_sharpe, +1 for waiting until the core issue is resolved, we have time until 9.5.x is end of life, however, if you want to add your own function for the issue, I don't think it would block incorporating the upstream fix down the road.

@devil2005, the module wouldn't work as you'd expect without composer, since it requires a Drupal core patch anyway.

@devil2005, I would love to help out with this, however, I don't think it appropriate to do a git tutorial within an issue on drupal.org.

You may be able to find additional help in the Drupal Slack https://www.drupal.org/community/contributor-guide/reference-information... →

Agreed, I've created a custom function here for now and updated to allow editing existing grids. Now just needs some testing. Ideally we'd have tests here but I don't have any more time for dev on this currently, so some testing of CKE5 and more importantly CKE4 -> 5 would convince a merge here.

@devil2005 I've attached a dump of this MR; however, I would NOT use this in prod as it may change and suggest only using as a way to test this MR as a way to move this forward

Great work. The process for both admin and editor is smooth.
Only found couple of issues with classes when inserted

• null class on .ck-widget.bs_grid
• extra space in class on .ck-widget.row

Admin process

Editor process

That's perfect with #21, thanks a lot b_sharpe !!

Thanks @VladimirAus ! Fixed null / spacing and committing to get this into a release :)

Great job! By far one of the more complex conversions I've seen and you nailed it!

Automatically closed - issue fixed for 2 weeks with no activity.