[ansi-sql compliant updates] - postgresql/mssql/mysql/sqlite password_policy_update_8304

Coming across the issue with the update hook:
`password_policy_update_8304`

This is after updating from 3.0 to 4.0.0
At first with `drush updb` this update hook seems to hang , on a second attempt it fails and aborts:

```
> [error] Update failed: password_policy_update_8304
[error] Update aborted by: password_policy_update_8304
[error] Finished performing updates.
```
We cannot lock to 3.1 as suggested because we need 4.0.0 as trying to upgrade a project to D10

If my memory serves me correctly, a workaround to this issue is to uninstall the password_policy module, you may need to unwind some *.info.yml dependencies and rebuild caches to prevent other modules or custom modules from being uninstalled also. Once this module is uninstalled, install the 4.0.0+ password_policy.

You can test to see what happens by trying this drush command:

drush pmu password_policy;

If the only module that is proposed for uninstall is password_policy, this should make it easier.

Probably do this before upgrading the module.

Then in another step, upgrade the password_policy module and then install it/configure it.

Thank you for your reply, unfortunately trying to uninstall the module with drush seems to just hang.
This was after unwinding some of the *.info.yml to prevent dependencies from uninstalling first.

Not able to give it another go at the moment but will try again at a later date..and try to get more info.

@Michelle-Buckby, you're in luck, I've written a patch for this.

I haven't tested this with mysql yet, however it works with Postgresql.

I confirm that the patch in #12 works with Postgresql. Thanks

Thank you @joseph.olstad , just getting back here to say I've successfully updated Password Policy on two projects now, no further issues related to this.

RTBC
based on comment #14

ok this is RTBC for Postgresql, however if someone with MariaDB or MySQL could please test to make sure this works in MySQL, that'd be great, with that said, I could synthesize a test to see myself , I'll write some synthetic test code to try this on mariadb/mysql and see if this is compatible.

This patch works great with Postgresql, however it fails with MariaDB/MySQL as follows:

SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 't1 USING "password_policy_history" t2 WHERE t1.id < t2.id AND t1.pass_hash = ...' at line 1: DELETE FROM "password_policy_history" t1 USING "password_policy_history" t2 WHERE t1.id < t2.id AND t1.pass_hash = t2.pass_hash AND t1.timestamp = t2.timestamp; Array

I think this query should be rewritten.

ok brute force fix for all Postgresql AND MariaDB/MySQL.

Delete ALL the history. Some might not like this but I'm guessing most will approve.

Kristen Pol → credited D2ev → .

Kristen Pol → credited paulocs → .

Adding credit for work on duplicate issue:

🐛 sql server password_policy_update_8304 failed with error Closed: duplicate

This should be against 4.0.x as 8.x branches are no longer supported, so changing version.

Assigning to myself for review.

Kristen Pol → credited shahin-raza → .

Adding credit from duplicate issue:

🐛 Password policy update is failing for postgreSQL database while doing drush updb Closed: duplicate

Updating the summary to provide more context.

Minor wording change to summary.

Thanks everyone for your work on this issue. I've merged the fix and included updated/more comments for more clarification on what happened.

Automatically closed - issue fixed for 2 weeks with no activity.

Kristen Pol → credited gatorjoe → .

Kristen Pol → credited jweowu → .

Kristen Pol → credited maxdmayhew → .

Kristen Pol → credited pavel.bulat → .

Kristen Pol → credited ThomWilhelm → .

Adding credit from ✨ Do not require user to re-run update 8301 to avoid error "user.field_pending_expire_sent field needs to be updated" Closed: duplicate .

Kristen Pol → credited achap → .

Kristen Pol → credited Ahmad Khader → .

Kristen Pol → credited alberto56 → .

This is part of the new 4.0.1 release → .

Thanks @Kristen Pol, definately the right call here, every system is supported.

Thanks for the credit on this also! :)