- Merge request !2812Issue #3312049: [Followup] Fix Drupal.Commenting.FunctionComment.MissingReturnType returns for NULL β (Open) created by Sweetchuck
- last update
over 1 year ago 29,386 pass, 1 fail - last update
over 1 year ago 29,400 pass - Status changed to Needs review
over 1 year ago 1:55pm 1 June 2023 - Status changed to Needs work
over 1 year ago 2:34pm 1 June 2023 - πΊπΈUnited States smustgrave
Can the MR be updated for 11.x please.
11.x is the current development branch, so code has to be committed there first to be backported.
- last update
over 1 year ago 29,402 pass - @sweetchuck opened merge request.
- Status changed to Needs review
over 1 year ago 6:21pm 1 June 2023 - Status changed to Needs work
over 1 year ago 9:28pm 1 June 2023 - πΊπΈUnited States smustgrave
So searching for " but return statement is missing" there still appear to be 89 instances in phpstan-baseline. Were those left out specifically?
- ππΊHungary Sweetchuck Budapest
Give them a closer look.
For example this one: \Drupal\Core\Database\Query\Delete::execute
- Status changed to Needs review
over 1 year ago 11:55am 2 June 2023 - Status changed to Needs work
over 1 year ago 7:41pm 3 June 2023 - πΊπΈUnited States smustgrave
Think it needs to be documented why we are skipping these 89 instances
Some functions are
save(),
getFormId(),
validateForm(),
etcIf the inherited docs say it returns a value and we are leaving in the phpstan file think it needs to be stated why.
- Open on Drupal.org βEnvironment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Not currently mergeable. - last update
over 1 year ago 29,372 pass, 12 fail - Open on Drupal.org βEnvironment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Not currently mergeable. - last update
over 1 year ago 29,460 pass, 12 fail