Change entity creation tasks in RssTest to use API calls

Missed the 9.5 window

At this time we will need a D10 MR.

Hiding the patch files to avoid review confusion.

Thanks @rpayanm

Refactor of the test looks good.

@joachim, thanks for writing up the steps you took to resolve this. I followed those steps and it was easy to follow and understand why you made the changes you did. I hope others find it useful.

As the issue summary states the changes here are part of the setup, not the actual test. Therefore, why are these changes not in the setUp method? I think they should be moved there. There is only one test method in this file, so there won't be any conflicts.

I've rebased on to 10.1.

> As the issue summary states the changes here are part of the setup, not the actual test. Therefore, why are these changes not in the setUp method? I think they should be moved there. There is only one test method in this file, so there won't be any conflicts.

I really don't think it's worth the effort. First, it would mean having to declare the term entities as class properties instead of them just being local vars:

 $term1 = $this->createTerm($this->vocabulary);

Second, and this is purely a personal feeling, I tend to do modules and config setup in setUp() and create content entities in the test method. Then again, creating $this->user is often done in setUp().

Third, it makes no difference since there is only one test method, but if ever we wanted to add to the test, or split the test method, it would lead to more work.

MR 2659 is showing 1000s of file changes now. Not sure what the fix was or if it was a change to the RssTest.php only.

I forgot to change the target branch on the MR. Sorted now.

MR 2659 looking at the changes to RssTest.php and they look fine and don't seem to break anything.

Committed 75110eb and pushed to 10.1.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.