- 🇺🇸United States jhedstrom Portland, OR
This looks great. Marking RTBC. Thanks!
- Status changed to Needs work
about 2 years ago 8:47pm 22 February 2023 - Status changed to Needs review
about 2 years ago 5:38am 23 February 2023 - 🇮🇳India mrinalini9 New Delhi
Rerolled patch #2, please review it.
Thanks!
The last submitted patch, 5: 3300631-5.patch, failed testing. View results →
- Status changed to Needs work
about 2 years ago 7:59pm 23 February 2023 - Status changed to Needs review
about 2 years ago 10:10pm 23 February 2023 - First commit to issue fork.
- Status changed to Needs work
about 1 month ago 3:10pm 1 April 2025 - 🇷🇴Romania claudiu.cristea Arad 🇷🇴
This looks like an API change which could break backwards compatibility for 3rd-parties. I would suggest to create new methods which are returning AccessResultInterface and deprecate the methods returning boolean
- 🇦🇺Australia nigelcunningham Geelong
I do agree that it breaks backwards compatibility, but it's also true that the current interface is broken - caching information is discarded, which could perhaps be counted as a security issue. No point treating it as one though (I think) since this issue has been public for so long.
If that logic makes sense, I'd argue that the logic should just be fixed an dependant modules should be forced to update to match as quickly as possible.
- 🇳🇱Netherlands idebr
#12 Return a boolean is now still valid, but triggers a deprecation