Contrib.social

Automated Drupal 10 compatibility fixes

Open on Drupal.org →
Created on 18 July 2022, over 2 years ago
Updated 6 October 2023, about 1 year ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects →

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago →
    🇺🇸United States greatmatter

    This patch should cover the D10 fixes from the last dev release.

  • Comment over 1 year ago →
    🇨🇦Canada nicoleannevella

    patch in comment #4 seems to be working. but does not pass the Upgrade Status module test as the version requirement in the .info.yml file needs to be updated to include ^10

  • Comment over 1 year ago →
    🇺🇸United States greatmatter

    Yeah--unfortunately I wasn't able to do that for a distribution/contrib... Sorry!

  • First commit to issue fork.
  • @snap_x opened merge request.
  • Comment over 1 year ago →
    🇺🇦Ukraine snap_x

    Thanks @greatmatter! Module works fine with patch #4, I tested it. I also created MR with changes that includes D10 .info.yml

  • First commit to issue fork.
  • Comment over 1 year ago →
    🇩🇪Germany semiaddict

    Thank you @greatmatter and @snap_x for this work!

    @snap_x, I added a commit to your MR, as the module was throwing an error after patching when using the LessphpCompiler.
    The commit simply changes the return value of the LessphpCompiler::complie method to adapt to changes done in ScssCompilerService::compile.

  • Comment over 1 year ago →
    project update bot

    This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

    It is important that any automated tests available are run with this patch and that you manually test this patch.

    Drupal 10 Compatibility

    According to the Upgrade Status module → , even with this patch, this module is not yet compatible with Drupal 10.

    Currently Drupal Rector, version 0.15.1, cannot fix all Drupal 10 compatibility problems.

    Therefore this patch does not update the info.yml file for Drupal 10 compatibility.

    Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

    Debug info

    Bot run #12554

    This patch was created using these packages:

    1. mglaman/phpstan-drupal: 1.1.35
    2. palantirnet/drupal-rector: 0.15.1
  • Comment over 1 year ago →
    🇺🇦Ukraine o_timoshchuk

    +1 RTBC Module works fine with patch #4, I tested it.

  • Comment over 1 year ago →
    🇸🇪Sweden ordermind

    Works fine for me too.

  • Comment over 1 year ago →
    🇮🇹Italy Giuseppe87

    The patch #12 misses a drupal_get_path and doesn't update the info inside scss_compiler.info.yml

  • Comment about 1 year ago →
    🇺🇸United States rclemings

    Patch 3298001-15.patch applies successfully to 8.x-1.x-dev but not 8.x-1.1.

  • Status changed to RTBC about 1 year ago
  • Comment about 1 year ago →
    🇮🇳India Bushra Shaikh

    I have reviewed and checked the patch #15 this works for drupal 9.5 and drupal 10.0. and 10.0.1
    Screenshots of the compatibility on 9.5 have been attached for reference:

    Can be move to RTBC+1

  • Status changed to Fixed about 1 year ago
  • Comment about 1 year ago →
    🇺🇦Ukraine seonic

    Thanks all, the patch 4 rises a drupal version to 9.3, because of extension.path.resolver and replaces deprecated methods of scssphp which requires to rise scssphp. I'll apply this changes to a new version 2.x with code refactoring. 1.x still will support 8.8, 9.0, 10.0

    file_put_contents($source_file['css_path'], trim($content->getCss())); will brake other compilers, a compiler plugin must returns content as string.
    D10 support added to the 1.x version.

  • Comment about 1 year ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024