Support CTools 4

Another workaround to be able to install without using additional composer repositories is to require Ctools 4 like this:
"drupal/ctools": "4.0.3 as 3.13.0",

So cloudflare and pathauto are happy about the requirement.

Patch no longer applies due to change in other requirements. Needs to be rerolled.

Rerolled and created a second branch for the 2.x release. Seems a simple thing to take care of.

Should 2.0.x maybe only require ctools:^4.0 in composer.json, because 2.0.x will be only compatible with D10 or higher and so we could remove this backward compatibility to ctools 3?

Are there any plans to release a new version with this one merged?

Oh hi past me. Still can't get this installed :(

re: #22 being as I suspect there's no compatibility this module really has to do I'm not sure it matters but probably.

Since this has been RTBC for a while, could a maintainer please comment on the delay? Thanks in advance.

Hi, would it be possible for a maintainer to take a look at Scott's MR? Please let me know if there is anything I can do to help get a new release that fixes this issue.

Also keen to have this merged, +1.

+1 to have this merged.

jcnventura → changed the visibility of the branch 3293730-support-ctools-4-2.x to hidden.

jcnventura → changed the visibility of the branch 3293730-support-ctools-4-2.x to active.

jcnventura → changed the visibility of the branch 3293730-support-ctools-4 to hidden.

Please, please merge this..

Please merge.

Thanks,
Sadashiv

Note that there are more issues with a Drupal 10.2 install at this point, including requiring cloudflare SDK which in turn requires guzzlehttp/guzzle ^6.2.2. Not that this issue shouldn't be merged but maybe it explains the delay?

@dmudie can you elaborate more?

including requiring cloudflare SDK which in turn requires guzzlehttp/guzzle ^6.2.2

When I check the latest release it is requiring v7
"guzzlehttp/guzzle": "^7.0.1",

When I install this cloudflare module with the issue fork it installs fine.

ctools guzzle requirements don't conflict with the cloudflare sdk requirements for me, this just needs the version of ctools bumped.

@EHLOVader when I try to install with the issue fork I get:

Problem 1

    - cloudflare/sdk[1.0.0, ..., 1.1.6] require guzzlehttp/guzzle ^6.2.2 -> found guzzlehttp/guzzle[6.2.2, ..., 6.5.8] but the package is fixed to 7.8.1 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.

    - cloudflare/sdk[1.1.7, ..., 1.3.0] require psr/http-message ~1.0 -> found psr/http-message[1.0, 1.0.1, 1.1] but the package is fixed to 2.0 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.

Ah, thank you @dmudie, I appreciate the follow up.

Sorry I missed that detail.

That module appears to also support ^7.0 but maybe something funny is happening with the dependencies since it can also use ^6.0
"guzzlehttp/guzzle": "~6.1|^7.0"

I did a quick test, but it appears to install fine with the drupal/cloudflare:dev-3293730-support-ctools-4-2.x issue fork that is part of the merge request.

These are the modules I have installed (of relation to this issue). So I think I must be missing something else if this can't be merged as is.

d8-contrib-modules/cloudflarephpsdk 1.0.0
drupal/cloudflare                   dev-3293730-support-ctools-4-2.x 45e99be
drupal/core-recommended             10.2.3
drupal/ctools                       4.0.4

d8-contrib-modules/cloudflarephpsdk hasn't been part of the source code for this for more than a year (see ✨ Proposal to switch Cloudflare library Fixed ).

The version of the code that uses that requirement was just before Drupal 10 support was added. Not sure why your composer would be requiring d8-contrib-modules/cloudflarephpsdk.. Maybe try to completely remove drupal/cloudflare and then require it again.. That should get rid of the old dependency unless you are explicitly requiring it somewhere.

Thanks @jcventura so, if it isn't using that cloudflarephpsdk, that cloudflarephpsdk doesn't have dependency conflicts with guzzle, Drupal 10.2 doesn't have guzzle conflicts, and ctools 4 doesn't have guzzle conflicts was there anything else preventing this from being merged?

What needs to be done to move this forward?

Sadly, only a maintainer who cares. That is the sad underbelly of Drupal today.. People are doing their 9-5 jobs, and no one actually cares about maintaining the software they use.

Problem with D10.2 seems to be related to psr/http-message: ~1.0 requirement of cloudflare/sdk package which conflicts with psr/http-message requirement of Drupal core 10.2.

I think biggest problem with cloudflare/sdk is that Cloudflare announced it as deprecated and will not provide development here anymore.
https://github.com/cloudflare/cloudflare-php/issues/235

So we could try to fork cloudflare/sdk and add possibility to also allow usage of psr/http-message:2.x but I think it will only solve our issue temporary because of developer resources.
https://github.com/cloudflare/cloudflare-php/issues/249

In general it would be better to use provided Cloudflare API v4 in drupal/cloudflare module instead of cloudflare/sdk.

@IT-Cru, please don't hijack this issue. This is about adding supprt to Ctools 4. Ctools 4 is EXACTLY the same code as Ctools 3, so the proposed solution is enough.

This is not about Drupal 10 support.

@jcnventura My intention wasn't to highjack this issue. Only wanted to provide information why tests for 10.2 are currently failing and in what direction at the end we should move.

I totally agree that MR which also allow ctools 4.x should be merged, but on the other hand maintainers could be stucked, when CI testing fails.

@IT-Cru, understood your point. It's just that it's so hard to get issues to RTBC, and this one didn't need a status change.

Note that I already use cloudlfare, ctools 4 and drupal 10.2 using a composer version override by requiring ctools like this:

"drupal/ctools": "4.0.4 as 3.99",

And yes, we do have a problem with the fact that cloudflare/sdk is deprecated, but that is correctly the subject of its own issue.

oh, thanks for sharing your work around on this @jcnventura

"drupal/ctools": "4.0.4 as 3.99",

I don't think I'd known this was possible. It will help add to my notes on using the fork to install from.

And thanks for helping explain the failing on CI @IT-Cru I wondered why it was failing if I can get it to work on my own.

I've rebased open MR to get Gitlab CI jobs running for this issue now.

All pipelines are green with drupal/ctools (4.0.4) downloaded at composer CI job.

@jcnventura: Do you remember if any changes in your projects are needed when Cloudflare module is used with ctools 4.0.x?

@RoSk0: If nothing more is needed I would say this could be a candidate for merge and a quick release :)

@IT-Cru The best way to reply on changes to anything when switching to ctools 4 is the fact that ctools 8.x-3.14 and 4.0.4 are EXACTLY the same code, as can be seen here: https://git.drupalcode.org/project/ctools/-/network/8.x-3.x?ref_type=heads

(and yes, I do think it is strange that 4.0.4 is being tagged in the 8.x-3.x branch..., when both a 4.x and a 4.0.x branch exist)

The change has been merged in. I will roll a new release shortly.

mandclu → closed merge request !8

Automatically closed - issue fixed for 2 weeks with no activity.