Remove call_user_func_array() from ModuleHandler::invoke() + invokeAll()

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

There's performance measures of calls to hooks, for me the winner is fast-callable syntax after replacing fast-call with $ff(...$args) as patch in #3259716-67: Replace usages of static::class . '::methodName' to first-class callable syntax static::method(...) →

https://gist.github.com/donquixote/85efcca90056111e967dd14cb1f9de9c

	--- a/core/lib/Drupal/Core/Extension/ModuleHandler.php
		+++ b/core/lib/Drupal/Core/Extension/ModuleHandler.php
		@@ -384,7 +384,7 @@ public function hasImplementations(string $hook, $modules = NULL): bool {
		    */
		   public function invokeAllWith(string $hook, callable $callback): void {
		     foreach (array_keys($this->getImplementationInfo($hook)) as $module) {
		-      $hookInvoker = \Closure::fromCallable($module . '_' . $hook);
		+      $hookInvoker = ($module . '_' . $hook)(...);
		       $callback($hookInvoker, $module);
		     }
		   }
		@@ -396,8 +396,8 @@ public function invoke($module, $hook, array $args = []) {
		     if (!$this->hasImplementations($hook, $module)) {
		       return;
		     }
		-    $hookInvoker = \Closure::fromCallable($module . '_' . $hook);
		-    return call_user_func_array($hookInvoker, $args);
		+    $hookInvoker = ($module . '_' . $hook)(...);
		+    return $hookInvoker(...$args);
		   } 

Only one test failed!

Found 1 more code example but 3 in comments that maybe should be addressed too?