- πΊπΈUnited States laura.gates
Patch works as expected in 9.5.x. This is ready for port.
- @lauragates opened merge request.
- π²π¦Morocco chaimaariz France
The patch is working, but there are still some bugs that need to be fixed on Drupal 10.
I'm getting this error with the version 4.1.0:
TypeError : Symfony\Component\HttpFoundation\Request::create(): Argument #1 ($uri) must be of type string, null given, called in /var/www/html/web/modules/contrib/search_api_glossary/src/Plugin/facets/processor/GlossaryAZAllItemsProcessor.php on line 79 dans Symfony\Component\HttpFoundation\Request::create() (ligne 321 de /var/www/html/vendor/symfony/http-foundation/Request.php).I created a patch to fix this error.
- Status changed to Needs review
over 1 year ago 3:13pm 5 April 2023 - First commit to issue fork.
- Status changed to RTBC
over 1 year ago 2:45pm 6 July 2023 - πΊπΈUnited States laura.gates
Re-patched based on the updated MR. Patch applies and no longer appears as incompatible with the Upgrade Status module.
- πΊπ¦Ukraine snap_x
Thanks for the patches.
+1 RTBC. Tested on Drupal 10 with patch from MR. Works perfectly for me. - Assigned to Kristen Pol
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
I forgot I was added to this module in 2021 to create the Drupal 9 release. I'll try to get this merged now and make a release.
Thanks to @nginex for the request.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Given it's the MR that was RTBC'ed, I'm hiding the patches from the list.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
I had to doublecheck the core_version_requirement as I hadn't seen >=8 used before, I don't think. The docs say this is fine: https://www.drupal.org/node/3070687 β
What I am confused about is that the latest MR just has the version change yet there were previous patches/MR also changed one line:
https://www.drupal.org/files/issues/2023-04-05/Fix-argument-type-search-... β
https://git.drupalcode.org/project/search_api_glossary/-/merge_requests/...
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
I see @codebymikey removed the casting in #8 with comment
Remove unnecessary string casting.
Yet @chaimaariz added it in #6 due to the error noted.Since, it appears, both @laura.gates and @snap_x tested with the latest MR and didn't have issues, then I will move forward with this merge.
@chaimaariz Please provide steps to reproduce your error if you are still having it with the latest MR.
-
Kristen Pol β
committed 9f93cdaf on 8.x-4.x authored by
chaimaariz β
Issue #3289515 by laura.gates, codebymikey, Project Update Bot,...
-
Kristen Pol β
committed 9f93cdaf on 8.x-4.x authored by
chaimaariz β
- Status changed to Fixed
over 1 year ago 9:55pm 27 July 2023 - πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
This has been merged and will be part of this release: π Create 8.x-4.2 release. Fixed
- Issue was unassigned.
- Status changed to Fixed
over 1 year ago 10:01pm 27 July 2023 - πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA