Automated Drupal 10 compatibility fixes

The patch in #11 is not sufficient. Here's something else that needs to be addressed: LanguageSwitchingTest uses the stable theme, but the stable theme is deprecated.

https://git.drupalcode.org/project/lang_dropdown/-/blob/8.x-2.x/tests/sr...

Ideally we change that to stark. There's also the option of pulling in the contrib stable through composer, but using stark would be better.

Following errors/warnings also needs to be fixed:

------ ----------------------------------------------------------------------- 
  Line   src/Form/LanguageDropdownForm.php                                      
 ------ ----------------------------------------------------------------------- 
  70     Property Drupal\lang_dropdown\Form\LanguageDropdownForm::$renderer     
         has unknown class                                                      
         Drupal\lang_dropdown\Form\Drupal\Core\Render\RendererInterface as its  
         type.                                                                  
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols     
  188    Variable $language in empty() always exists and is not falsy.          
  203    Access to an undefined property                                        
         Symfony\Component\HttpFoundation\RequestStack::$query.                 
  231    Call to method renderPlain() on an unknown class                       
         Drupal\lang_dropdown\Form\Drupal\Core\Render\RendererInterface.        
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols     
  365    Access to an undefined property                                        
         Symfony\Component\HttpFoundation\RequestStack::$query.                 
 ------ ----------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------ 
  Line   src/Plugin/Block/LanguageDropdownBlock.php                                    
 ------ ------------------------------------------------------------------------------ 
  682    Variable $code in PHPDoc tag @var does not exist.                             
  682    Variable $values in PHPDoc tag @var does not exist.                           
  763    Method Drupal\Core\Form\FormBuilderInterface::getForm() invoked with          
         4 parameters, 1 required.                                                     
  812    Call to an undefined method                                                   
         Drupal\Core\TypedData\TranslationStatusInterface::getTranslationLanguages().  
 ------ ------------------------------------------------------------------------------ 

 [ERROR] Found 9 errors                                                         

Carlos Romero → made their first commit to this issue’s fork.

I am attaching patch with compatibility fixes related with #12 and #13.
For #12 as recommended I changed theme to "stark" and tests are passing on my local environment.
For #13 everything should be fixed except

Method Drupal\Core\Form\FormBuilderInterface::getForm() invoked with
4 parameters, 1 required.

I don't know if we can do anything else than // @phpstan-ignore-next-line

I am attaching patch with compatibility fixes related with #12 and #13.
For #12 as recommended I changed theme to "stark" and tests are passing on my local environment.
For #13 everything should be fixed except

Method Drupal\Core\Form\FormBuilderInterface::getForm() invoked with
4 parameters, 1 required.

I don't know if we can do anything else than // @phpstan-ignore-next-line

Note to others out there in Drupal-land:
The patch in #17 is meant for the 2.x-dev@dev branch. It cannot be applied to the 8.x-2.0 release. It does, however, apply cleanly to the dev branch.

✅ Released lang_dropdown-8.x-2.1 →

This issue was preventing me from updating certain sites to Drupal 10. Thanks, Rajab!

Automatically closed - issue fixed for 2 weeks with no activity.