Automated Drupal 10 compatibility fixes

Created on 15 June 2022, over 2 years ago
Updated 18 January 2024, 11 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects โ†’

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot โ†’ official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot โ†’ or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot โ†’ , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue โ†’ . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue โ†’ .

๐Ÿ“Œ Task
Status

Fixed

Version

1.0

Component

Code

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • ๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom jonnyhocks

    I've created a fork and opened a merge request after having applied the patch in #6

  • Status changed to RTBC over 1 year ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia NishaVaghela

    I have applied and tested the patch in comment #6, the module is working as expected.
    The module in now compatible to Drupal10 , thus moving the issue to RTBC.

  • ๐Ÿ‡ณ๐Ÿ‡ฟNew Zealand xurizaemon ลŒtepoti, Aotearoa ๐Ÿ

    Patch here doesn't apply for me to the current release, but does apply if I install the 1.x-dev release + patch.

    composer require 'drupal/hierarchical_term_formatter:1.x-dev#26e21f18e'
    
  • Open in Jenkins โ†’ Open on Drupal.org โ†’
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 8
    last update over 1 year ago
    13 pass
  • ๐Ÿ‡ต๐Ÿ‡ฑPoland driverok

    MR!5 works for me.

  • ๐Ÿ‡ฆ๐Ÿ‡นAustria jovan1348

    You will also need this patch, couse render() function in not more availble in D10, and replaced with Drupal secrvice

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia deepaksingh05

    If you are using 8.x-1.2 version then you can use this Patch!

    diff --git a/hierarchical_term_formatter.info.yml b/hierarchical_term_formatter.info.yml
    index c35f933..257b53f 100644
    --- a/hierarchical_term_formatter.info.yml
    +++ b/hierarchical_term_formatter.info.yml
    @@ -2,7 +2,7 @@ type: module
     name: Hierarchical Term Formatter
     description: 'Provides hierarchical term formatters for taxonomy reference fields.'
     package: Field Formatters
    -core_version_requirement: ^8.7.7 || ^9
    +core_version_requirement: ^9.3 || ^10
     
     # Information added by Drupal.org packaging script on 2020-05-24
     version: '8.x-1.2'
    diff --git a/hierarchical_term_formatter.theme.inc b/hierarchical_term_formatter.theme.inc
    index b18dc9d..0f0e6a8 100755
    --- a/hierarchical_term_formatter.theme.inc
    +++ b/hierarchical_term_formatter.theme.inc
    @@ -23,7 +23,7 @@ function template_preprocess_hierarchical_term_formatter(array &$variables) {
           $url = new Url('entity.taxonomy_term.canonical', ['taxonomy_term' => $term->id()]);
           $link = Link::fromTextAndUrl($term->getName(), $url);
           $link = $link->toRenderable();
    -      $terms[] = render($link);
    +      $terms[] = \Drupal::service('renderer')->render($link);
         }
         else {
           $terms[] = $term->getName();
    diff --git a/tests/src/Functional/HierarchicalTermFormatterErrorTest.php b/tests/src/Functional/HierarchicalTermFormatterErrorTest.php
    index 80ba55b..1e7e858 100755
    --- a/tests/src/Functional/HierarchicalTermFormatterErrorTest.php
    +++ b/tests/src/Functional/HierarchicalTermFormatterErrorTest.php
    @@ -41,7 +41,7 @@ class HierarchicalTermFormatterErrorTest extends BrowserTestBase {
        *
        * @var array
        */
    -  public static $modules = [
    +  protected static $modules = [
         'user',
         'node',
         'taxonomy',
    @@ -52,7 +52,7 @@ class HierarchicalTermFormatterErrorTest extends BrowserTestBase {
       /**
        * {@inheritdoc}
        */
    -  protected function setUp() {
    +  protected function setUp(): void {
         parent::setUp();
         // Create a tree we can work on.
         $items = [
    @@ -88,7 +88,7 @@ class HierarchicalTermFormatterErrorTest extends BrowserTestBase {
         $this->drupalLogin($this->user);
     
         $this->drupalGet("node/$nid/preview/$view_mode");
    -    $this->assertResponse(200);
    +    $this->assertSession()->statusCodeEquals(200);
     
         // Should be the same if we remove the term.
         $term = $this->container->get('entity_type.manager')->getStorage('taxonomy_term')->load($this->createdTerms['1.1.1']);
    @@ -96,7 +96,7 @@ class HierarchicalTermFormatterErrorTest extends BrowserTestBase {
     
         $this->container->get('cache_tags.invalidator')->invalidateTags($node->getCacheTagsToInvalidate());
         $this->drupalGet("node/$nid/preview/$view_mode");
    -    $this->assertResponse(200);
    +    $this->assertSession()->statusCodeEquals(200);
     
         $this->drupalLogout();
       }
    diff --git a/tests/src/Functional/HierarchicalTermFormatterTest.php b/tests/src/Functional/HierarchicalTermFormatterTest.php
    index f24429c..c9065b3 100755
    --- a/tests/src/Functional/HierarchicalTermFormatterTest.php
    +++ b/tests/src/Functional/HierarchicalTermFormatterTest.php
    @@ -47,7 +47,7 @@ class HierarchicalTermFormatterTest extends BrowserTestBase {
        *
        * @var array
        */
    -  public static $modules = [
    +  protected static $modules = [
         'user',
         'node',
         'taxonomy',
    @@ -73,7 +73,7 @@ class HierarchicalTermFormatterTest extends BrowserTestBase {
       /**
        * {@inheritdoc}
        */
    -  protected function setUp() {
    +  protected function setUp(): void {
         parent::setUp();
         // Create a tree we can work on.
         $items = [
    @@ -126,7 +126,7 @@ class HierarchicalTermFormatterTest extends BrowserTestBase {
             $expected_value = $this->generateLinkString($expected_value['items'], $expected_value['separator']);
           }
           $this->drupalGet("node/$nid/preview/$display_mode");
    -      $this->assertRaw(">$expected_value<");
    +      $this->assertSession()->responseContains(">$expected_value<");
         }
     
         $this->drupalLogout();
    
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia deepaksingh05

    If you are using 8.x-1.2 version then you can use this Patch!

  • ๐Ÿ‡ณ๐Ÿ‡ฑNetherlands pefferen

    Patch in #17 works nicely on our codebase, please merge

  • Have been running patch in#17 for a few days on Drupal 10 now and haven't encountered any issues yet.

  • ๐Ÿ‡น๐Ÿ‡ญThailand Nick Hope

    Composer successfully applies #6 to 8.x.1.x-dev and it works for me in D9.5.11.

    The change in #15 was already included in #6 (and in #17).

    #17 is very similar to #6 but I can't get Composer to apply it to 8.x-1.2.

  • First commit to issue fork.
  • Status changed to Fixed 12 months ago
  • ๐Ÿ‡บ๐Ÿ‡ฆUkraine AstonVictor

    The MR was merged.

    Changes will be added to the next release.
    Also, checked the module with CS and PhpStan.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024