Account created on 9 November 2017, over 7 years ago
#

Merge Requests

More

Recent comments

πŸ‡΅πŸ‡±Poland driverok

To reproduce the issue just try importing split configuration via UI

πŸ‡΅πŸ‡±Poland driverok

Thanks for your effort during Epam Drupal open-source week #14!

πŸ‡΅πŸ‡±Poland driverok

Thanks guys for your effort during EPAM contribution week #14!

πŸ‡΅πŸ‡±Poland driverok

driverok β†’ made their first commit to this issue’s fork.

πŸ‡΅πŸ‡±Poland driverok

Thanks a.kovrigin for the patch, merged

πŸ‡΅πŸ‡±Poland driverok

Please review the MR77 with simple fix.

I've checked it should work.

Please notice the fix goes to the JS source, so in order to work you probably have to run npx webpack inside the openai_ckeditor submodule ( and before that yarn install)

πŸ‡΅πŸ‡±Poland driverok

Could the role be granted to the SAVEL β†’ instead?

Should we create a new issue or it could be handled in the scope of this one?

Thanks!

πŸ‡΅πŸ‡±Poland driverok

Hi, thanks for the review and suggestions.

I'm not sure I understand the last one, related to only my commits.

I do not have any dedicated module/theme, where only I'm the owner - all my modules are written with co-maintainers.

Maybe the gitlab page with all my activities might work here? - https://git.drupalcode.org/driverok

Thanks!

πŸ‡΅πŸ‡±Poland driverok

Thanks everyone for your effort during EPAM Drupal open-source contribution week # 13!

πŸ‡΅πŸ‡±Poland driverok

Thanks guys for your effort during EPAM contribution week #13!

πŸ‡΅πŸ‡±Poland driverok

driverok β†’ made their first commit to this issue’s fork.

πŸ‡΅πŸ‡±Poland driverok

checked MR!4835 - fixed the problem for me.

STR - any Drupal 7 site with incorrectly ( not fully ) deleted fields (instances). Basically, everything that makes drupal_get_schema() return False.

Thanks @Pavel_SPN!

πŸ‡΅πŸ‡±Poland driverok

the patch #2 is working well for me

πŸ‡΅πŸ‡±Poland driverok

MR!6 reviewed and worked. Please merge it to avoid complex workarounds. Thanks!

πŸ‡΅πŸ‡±Poland driverok

this one probably could be closed as already fixed in the latest 7.x-4.x branch

πŸ‡΅πŸ‡±Poland driverok

One more open question - how to make the image upload button work for the CKEditor 5? (Previously drupal media browser opens when we click to image upload button in CKEditor toolbar)

πŸ‡΅πŸ‡±Poland driverok

Hi, thanks for your effort.

    Here is my feedback:

    1. build_ckeditor5.sh script is not fully working. - I've got a couple of errors related to the wrong path to different files (like error tsconfig.types.json:2:13 - error TS6053: File 'ckeditor5/tsconfig.json' not found). I was able to fix it manually
    2. After running a script there is no README.md file, which is required to determine the version. The only way I found is to download the CKEditor from the https://ckeditor.com/ckeditor-5/download/ and manually add the README.md from the downloaded version.
    3. wysiwyg_ckeditor5_version function does not return correctly the version, due to the regexp preg_match('% build v([0-9.]*)/%', $library, $matches);. Fixed by removing the / at the end of regexp

    After all the above I was able to add it to the page admin/config/content/wysiwyg and use it. After all, the CKEditor is loaded, but without the full buttons bar ( probably it is some misconfiguration from my side.

    The same result after applying the patch to the module and just downloading the library from the https://ckeditor.com/ckeditor-5/download/ page.

πŸ‡΅πŸ‡±Poland driverok

Thanks for participation in Epam Drupal open-source week #12!

πŸ‡΅πŸ‡±Poland driverok

Thanks for participation in Epam Drupal open-source week #11!

πŸ‡΅πŸ‡±Poland driverok

Thanks for your effort in mentoring Epam Drupal open-source contrib week #11!

Production build 0.71.5 2024