Automated Drupal 10 compatibility fixes

Thank you for your efforts in making this D10 compatible! I see changes are already part of the main 2.x branch, any reason why this ticket is not mark as close yet? Is there any plan of releasing a D10 compatible version anytime soon?

pefferen → credited pgrond → .

@ademarco That is because new patches can be added by the D10 bot because the 'ProjectUpdateBotD10' has been added to this ticket, please see the 'problem/motivation' of this issue.

I will find some time soon to check out the new patches by @burnellw_cit

Hey @pefferen thanks by bring clear here about this issue.

After upgrade to 8.x-2.0-alpha6 external entities got broken for me, it could not correctly get value for some properties, for example, label.

Found that it happens due to use doCreate method in mapFromRawStorageData, there are seems some differences for external entities between these two way of creation:

$entity = new $entity_class([], $this->entityTypeId, $bundle);
$this->initFieldValues($entity, $values);

and

$entity = new $entity_class($values, $this->entityTypeId, $bundle);

I didn't investigate more deep, just suggest to rollback usage of doCreate.

The last submitted patch, 18: 3287410-18.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

I upload a new patch that includes some additional fixes for 8.x-2.0-alpha6.

Patch failed to apply, marking "Needs Work"

For me the #20 patch is working fine. Additionally we can upgrade to the 2.0@alpha version that addressed D10 compatibility.

<ul>
  <li>ddev composer install</li>
  <li>Gathering patches for root package.</li>
  <li>Removing package drupal/external_entities so that it can be re-installed and re-patched.</li>
  <li>  - Removing drupal/external_entities (2.0.0-alpha6)</li>
  <li>Deleting /var/www/html/modules/contrib/external_entities - deleted</li>
  <li>Installing dependencies from lock file (including require-dev)</li>
  <li>Verifying lock file contents can be installed on current platform.</li>
  <li>Warning: The lock file is not up to date with the latest changes in composer.json. You may be getting outdated dependencies. It is recommended that you run `composer update` or `composer update <package name>`.</li>
  <li>Package operations: 1 install, 0 updates, 0 removals</li>
  <li>Gathering patches for root package.</li>
  <li>Gathering patches for dependencies. This might take a minute.</li>
  <li>  - Installing drupal/external_entities (2.0.0-alpha6): Extracting archive</li>
  <li>  - Applying patches for drupal/external_entities</li>
  <li>    patches/3287410-19-alpha6.patch (External entities D10 patch)</li>
  <li></li>
  <li>Generating autoload files</li>
  <li>Hardening vendor directory with .htaccess and web.config files.</li>
  <li>91 packages you are using are looking for funding.</li>
  <li>Use the `composer fund` command to find out more!</li>
  <li>phpstan/extension-installer: Extensions installed</li>
  <li>  * Homepage: https://www.drupal.org/project/drupal</li>
  <li>  * Support:</li>
  <li>    * docs: https://www.drupal.org/docs/user_guide/en/index.html</li>
  <li>    * chat: https://www.drupal.org/node/314178</li>
  <li>Cleaning installed packages.</li>
</ul>

the patch in #20 does not apply anymore.

MR !24 contains errors

patch for alpha 7

avoiding a conflict with the external_entities.info.yml between dev and tagged release.

thanks all, slightly altered patch in #33, removed Default TRUE value from accessCheck().

committed to dev

pefferen → closed merge request !24

Thanks @pefferen

@pefferen, it is normal to wait two weeks and let drupal.org automatically close issues. Now that you have force closed this issue no one else can re-open it should there be a regression to report.

When an issue is marked as Fixed and has no activity for 2 weeks, it is closed automatically.

thanks, @josepholstad I did not know, reopening to fixed

Automatically closed - issue fixed for 2 weeks with no activity.