- πΊπΈUnited States smustgrave
Running against 10.1
Not sure this can be backported to 9.5 as this change is 8.1 specific and D9 claims to support 7.4
- Status changed to Fixed
over 1 year ago 9:04am 16 February 2023 - π¬π§United Kingdom catch
Committed/pushed to 10.1.x and cherry-picked to 10.0.x, thanks!
We have a meta issue open trying to remove the all ReturnTypeWillChange annotations.
- ππΊHungary Sweetchuck Budapest
https://git.drupalcode.org/project/drupal/-/blob/9.5.x/core/lib/Drupal/C...
Drupal 9 with PHP 8.1 still has this problem.
Should I reopen this issue and change the "version" to "9.5.x-dev"? - πΊπΈUnited States smustgrave
Think youβll have to patch for 9.5 as 9 claims to work with 7.4 and wonβt that change break those sites?
- ππΊHungary Sweetchuck Budapest
For PHP 7.4 lines like this
#[\ReturnTypeWillChange]
are just a simple comment, it does nothing with it.
Same as this onePHP 8.x handles this kind of comments in a special way.
https://www.php.net/manual/en/language.attributes.overview.php - Status changed to RTBC
over 1 year ago 10:39pm 16 February 2023 - π¬π§United Kingdom longwave UK
Reopening for backport to 9.5.x, but I would like the CI run to be clean first (the last failures were a different issue, but let's be sure)
- Status changed to Fixed
over 1 year ago 8:52am 17 February 2023 Automatically closed - issue fixed for 2 weeks with no activity.