generate sample values get dimensions wrong when min_resolution is bigger than 600x600

This patch file also adds a new test to check both the default case, and the bug issue.

Please review it.

I am removing the needs test tag, also changing status to Needs review.

Thanks for the tests. Just FYI for next time when adding tests it helps to upload a test-only patch followed by the full patch. Also an interdiff between patches.

But I ran the tests locally without the fix and it failed as expected

Failed asserting that 709 matches expected '800'.
Expected :800
Actual :709

Crediting @rootwork for mentoring, @quietone for a review and @smustgrave for running the test locally

Committed 4578bbd and pushed to 11.x. Thanks!

Backported to 10.1.x. Not backporting any further because 9.5.x and 10.0.x are now in security only mode.

Fixed on commit (comment was > 80 chars).

diff --git a/core/modules/image/tests/src/Kernel/ImageItemTest.php b/core/modules/image/tests/src/Kernel/ImageItemTest.php
index 037a6378300..a1879bb4428 100644
--- a/core/modules/image/tests/src/Kernel/ImageItemTest.php
+++ b/core/modules/image/tests/src/Kernel/ImageItemTest.php
@@ -155,7 +155,7 @@ public function testImageItem() {
   }
 
   /**
-   * Tests generateSampleItems() method under different min_resolution and max_resolution configurations.
+   * Tests generateSampleItems() method under different resolutions.
    */
   public function testImageItemSampleValueGeneration() {
 

Automatically closed - issue fixed for 2 weeks with no activity.