- πͺπΈSpain guiu.rocafort.ferrer Barcelona
This patch file also adds a new test to check both the default case, and the bug issue.
Please review it.
- last update
about 1 year ago 30,342 pass - Status changed to Needs review
about 1 year ago 12:39pm 22 June 2023 - πͺπΈSpain guiu.rocafort.ferrer Barcelona
I am removing the needs test tag, also changing status to Needs review.
- last update
about 1 year ago 29,554 pass - Status changed to RTBC
about 1 year ago 9:12pm 24 June 2023 - πΊπΈUnited States smustgrave
Thanks for the tests. Just FYI for next time when adding tests it helps to upload a test-only patch followed by the full patch. Also an interdiff between patches.
But I ran the tests locally without the fix and it failed as expected
Failed asserting that 709 matches expected '800'.
Expected :800
Actual :709 - last update
about 1 year ago 30,342 pass - π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Crediting @rootwork for mentoring, @quietone for a review and @smustgrave for running the test locally
-
larowlan β
committed fc4d59e3 on 10.1.x
Issue #3276965 by guiu.rocafort.ferrer, andregp, roberttabigue, quietone...
-
larowlan β
committed fc4d59e3 on 10.1.x
-
larowlan β
committed 4578bbd6 on 11.x
Issue #3276965 by guiu.rocafort.ferrer, andregp, roberttabigue, quietone...
-
larowlan β
committed 4578bbd6 on 11.x
- Status changed to Fixed
about 1 year ago 10:06pm 26 June 2023 - π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Committed 4578bbd and pushed to 11.x. Thanks!
Backported to 10.1.x. Not backporting any further because 9.5.x and 10.0.x are now in security only mode.
Fixed on commit (comment was > 80 chars).
diff --git a/core/modules/image/tests/src/Kernel/ImageItemTest.php b/core/modules/image/tests/src/Kernel/ImageItemTest.php index 037a6378300..a1879bb4428 100644 --- a/core/modules/image/tests/src/Kernel/ImageItemTest.php +++ b/core/modules/image/tests/src/Kernel/ImageItemTest.php @@ -155,7 +155,7 @@ public function testImageItem() { } /** - * Tests generateSampleItems() method under different min_resolution and max_resolution configurations. + * Tests generateSampleItems() method under different resolutions. */ public function testImageItemSampleValueGeneration() {
Automatically closed - issue fixed for 2 weeks with no activity.