- Status changed to Needs work
almost 2 years ago 8:55am 19 January 2023 - Status changed to Needs review
almost 2 years ago 3:42pm 19 January 2023 9.5 has some js test failure (AFAI can understand) and the second run passed.
Is there anything else to be done?- Status changed to Needs work
almost 2 years ago 4:14pm 2 March 2023 - 🇺🇸United States smustgrave
public function isInternal() {
Should have a typehint returnAlso adding a new function will require a change record.
Added type hind in
isInternal
method, keeping the status needs work for change record.- last update
over 1 year ago 29,460 pass - last update
over 1 year ago Build Successful - Status changed to Needs review
about 1 year ago 9:00am 20 October 2023 - Open on Drupal.org →Environment: PHP 8.2 & MySQL 8last update
about 1 year ago Not currently mergeable. - last update
about 1 year ago 29,673 pass - Open on Drupal.org →Environment: PHP 8.2 & MySQL 8last update
about 1 year ago Not currently mergeable. - @efpapado opened merge request.
- Status changed to RTBC
about 1 year ago 1:41pm 20 October 2023 - 🇺🇸United States smustgrave
Fixed up the Change record some.
Rest looks fine.
- last update
about 1 year ago 29,673 pass - 🇬🇧United Kingdom alexpott 🇪🇺🌍
@efpapado that MR against 11.x is not necessary. The MR against 10.1.x cna be applied to 11.x just fine.
Committed and pushed f91e76e505e to 11.x and 4e682c3a68e to 10.2.x. Thanks!
- Status changed to Fixed
about 1 year ago 9:59am 23 October 2023 -
alexpott →
committed f91e76e5 on 11.x
Issue #3274419 by Marios Anagnostopoulos, Shubham Chandra, ravi.shankar...
-
alexpott →
committed f91e76e5 on 11.x
-
alexpott →
committed 4e682c3a on 10.2.x
Issue #3274419 by Marios Anagnostopoulos, Shubham Chandra, ravi.shankar...
-
alexpott →
committed 4e682c3a on 10.2.x
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Discussed with @longwave - we agreed to backport to 10.1.x and remove the CR as it is not that helpful in this case.
-
alexpott →
committed 06c8b1dd on 10.1.x
Issue #3274419 by Marios Anagnostopoulos, Shubham Chandra, ravi.shankar...
-
alexpott →
committed 06c8b1dd on 10.1.x
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
This, for example, will remove the field from JSON:API results and might have other undesired consequences.
😮 wow, this was an important oversight in #2871591: Allow ComplexData in TypedData to specify computed properties that should be exposed in normalization and other contexts → ! Nice find.
Automatically closed - issue fixed for 2 weeks with no activity.