The method \Drupal\file\FileRepository::loadByUri use the \Drupal\Core\Entity\EntityHandlerBase::loadByProperties to load the files by uri property. When multiple files match to the uri the code loop throught the $files to break the loop and returns the first match, the problem is with the usage of the method loadByProperties, the results are sorted by chronological order.
Run the code $files = \Drupal::entityTypeManager()->getStorage('file')->loadByProperties(); and checks the array keys (which are files IDs), they are in chronological order.
Use the entity query instead the loadByProperty method as following code :
$fids = $fileStorage
->getQuery()
->condition('uri', $uri)
->accessCheck(FALSE)
->sort('fid', 'DESC')
->execute();
/** @var \Drupal\file\FileInterface[] $files */
$files = $fileStorage->loadMultiple($fids);
Needs work
10.1 ✨
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
Thank you for reporting
This will require a test case to show the issue.