FileRepository::loadByUri does not returns the most recent file if several files match the URI

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

Thank you for reporting

This will require a test case to show the issue.

I came across this issue while doing bugsmash triage.

I'm somewhat confused about the title

FileRepository::loadByUri does not returns the most recent file if several files match the URI

Since URI is unique value, I'm wondering how we can end-up with incorrect value.

i.e. the following snippet already does the exact validation of $uri and returns the value.

foreach ($files as $item) {
        // Since some database servers sometimes use a case-insensitive
        // comparison by default, double check that the filename is an exact
        // match.
        if ($item->getFileUri() === $uri) {
          return $item;
        }
      }