Prepare d10 compatibility

Created on 27 March 2022, over 2 years ago
Updated 23 January 2023, almost 2 years ago

Problem/Motivation

We want to replace all deprecated code to be compatible with Drupal 9 and 10.

Steps to reproduce

Run tests locally. Or look at the test results from the second commit to the MR: https://www.drupal.org/pift-ci-job/2347866 ā†’

Proposed resolution

Replace all deprecations that are listed in the test results.

Remaining tasks

Fix

User interface changes

none

API changes

none

Data model changes

none

šŸ“Œ Task
Status

Fixed

Version

2.0

Component

Code

Created by

šŸ‡³šŸ‡“Norway eiriksm Norway

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • šŸ‡ØšŸ‡¦Canada joseph.olstad

    @Zombienaute managed to get the MR to pass on D10.0.1 / PHP 8.1, congrats!

    I've triggered the PHP 8.2 tests with D10.0.1 now just to see how that's doing

  • šŸ‡ØšŸ‡¦Canada joseph.olstad

    PHP 8.2 fixes needed, (easy to fix)

    Missing $cron property, add it.public $cron;

      1x: Creation of dynamic property Drupal\Tests\linkchecker\Kernel\LinkcheckerRedirectTest::$cron is deprecated
        1x in LinkcheckerRedirectTest::testLinkcheckerRedirect from Drupal\Tests\linkchecker\Kernel
    

    Solution: Add a public property called $cron to LinkcheckerRedirectTest or it's parent class if that's easier

    Missing $adminUser property, add it. public $adminUser;

      1x: Creation of dynamic property Drupal\Tests\linkchecker\Functional\LinkCheckerEditFormTest::$adminUser is deprecated
        1x in LinkCheckerEditFormTest::testEditUrlWorks from Drupal\Tests\linkchecker\Functional

    again in:

      2x: Creation of dynamic property Drupal\Tests\linkchecker\Functional\LinkCheckerInterfaceTest::$admin_user is deprecated
        1x in LinkCheckerInterfaceTest::testLinkCheckerCreateNodeWithBrokenLinks from Drupal\Tests\linkchecker\Functional
        1x in LinkCheckerInterfaceTest::testLinkCheckerCreateBlockWithBrokenLinks from Drupal\Tests\linkchecker\Functional

    again in

      1x: Creation of dynamic property Drupal\Tests\linkchecker\Functional\LinkCheckerLinkExtractionStatusTest::$adminUser is deprecated
        1x in LinkCheckerLinkExtractionStatusTest::testLinkCheckerStatusCorrect from Drupal\Tests\linkchecker\Functional

    again in

      1x: Creation of dynamic property Drupal\Tests\linkchecker\Functional\LinkCheckerLinkExtractionTest::$adminUser is deprecated
        1x in LinkCheckerLinkExtractionTest::testLinkCheckerCreateNodeWithLinks from Drupal\Tests\linkchecker\Functional

    again in

      2x: Creation of dynamic property Drupal\Tests\linkchecker\Functional\LinkCheckerOverviewTest::$adminUser is deprecated
        1x in LinkCheckerOverviewTest::testOverviewWorks from Drupal\Tests\linkchecker\Functional
        1x in LinkCheckerOverviewTest::testOverViewWorksWithResultFilter from Drupal\Tests\linkchecker\Functional

    again in

      1x: Creation of dynamic property Drupal\Tests\linkchecker\FunctionalJavascript\LinkCheckerOverviewTest::$adminUser is deprecated
        1x in LinkCheckerOverviewTest::testOverviewWorks from Drupal\Tests\linkchecker\FunctionalJavascript
  • šŸ‡¦šŸ‡ŗAustralia VladimirAus Brisbane, Australia

    Thanks everyone. šŸ»

    āœ… closed šŸ“Œ Automated Drupal 10 compatibility fixes Closed: duplicate as duplicate
    āœ… Branch 2.0.x is ready for D10 testing!

    @joseph.olstad probably good idea to create PHP 8.2 compatibility as a separate task. šŸ™‹ā€ā™€ļø

  • Status changed to Fixed almost 2 years ago
  • šŸ‡¦šŸ‡ŗAustralia VladimirAus Brisbane, Australia
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024