- 🇮🇳India djsagar
Hi @sokru,
Encountering an Error When Applying Patch Locally
Code functions as intended, successfully resolving the issue.My recommend create MR.
Thanks!
- First commit to issue fork.
- Merge request !373gin-3271280/3271280-entity-browsersmall-source: Resolved entity-browser alignment issue. → (Open) created by Tirupati_Singh
- Status changed to Needs review
about 1 year ago 11:41am 29 January 2024 - 🇮🇳India Tirupati_Singh
Created MR for the entity-browser alignment issue. Please review.
- Status changed to Needs work
10 months ago 11:02am 14 June 2024 Hello there,
The steps to reproduce is not clearly mentioned over here, and I've digged up a lot, but haven't found any way to reproduce the issue.
Can anyone kindly help me reproduce the issue, so that I can test the patch and help the issue move forward.
Also the issue summary needs to be updated accordingly then, hence moving it to NW for now!
Thanks!- Status changed to Needs review
10 months ago 11:31am 14 June 2024 - 🇮🇳India Tirupati_Singh
@sourojeetpaul, updated the Steps to reproduce. Please have a look.
- Status changed to Needs work
10 months ago 12:11pm 14 June 2024 Hello @Tirupati_Singh,
Thanks for the update, now I can successfully reproduce the issue. I've also cross checked whether the issue is arising on different themes as well or not, and as its only occurring with Gin theme,hence we can conclude that the issue of the Gin theme only and not the module which is being used here. I'll attach all the screenshots for reference.
I've tried to apply your patch, though I haven't encountered any error on patch application, but unfortunately the patch is not helping to resolve the issue as well. So moving it back to NW state once again!Also as a suggestion I'd like to add that there should also be a breathing space b/w the checkbox and the image as well, as its there for other themes, and let's not only restrict for smaller images/icons. We should design in a such a way so that it doesn't seem to break irrespective of the image size!
- Status changed to Needs review
10 months ago 10:31am 18 June 2024 - 🇮🇳India Tirupati_Singh
Hi @sourojeet2001, I've fixed the Entity browser views display alignment issue and added space between the checkbox and the image as per the feedback. Attaching the screenshot for reference.
- Status changed to RTBC
10 months ago 10:52am 18 June 2024 Hi @Tirupati_Singh,
Thanks for putting efforts on making the recommended changes. The changes seems reasonable to me now, I've also applied the modified patch and can verify that it solves the issue, hence moving it to RTBC++
Attaching before after screenshots for reference!- Status changed to Needs work
4 months ago 12:38pm 18 December 2024 - 🇨🇭Switzerland saschaeggi Zurich
The MR needs a rebase and recompiled CSS. Also I left 2 code comments 👀