- Assigned to ressa
- last update
almost 2 years ago 29,402 pass - last update
almost 2 years ago 29,402 pass - Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 5:46pm 31 May 2023 - Status changed to Needs work
almost 2 years ago 9:17pm 31 May 2023 - πΊπΈUnited States smustgrave
Think it would be better to see if a preprocess hook can be used to add the attributes. This will require all contrib themes and sub themes to update their templates while a hook would not.
- π©π°Denmark ressa Copenhagen
Thanks for looking at it @smustgrave. I agree, a preprocess hook makes more sense. Hopefully someone with Drupal core coding skills can help out ...
- π©π°Denmark ressa Copenhagen
Thanks for updating the title! I have since learned of a probably better method, using JavaScript, which could be considered.
- π©π°Denmark ressa Copenhagen
I have updated the patch to use JavaScript instead. I could not find an active JavaScript file in Views, so to get it working, I simply dropped it into
/core/misc/drupal.js
, but eventually, the JavaScript should probably be in views_ui module. - π¬π§United Kingdom oily Greater London
Rebased and fixed merge conflicts. Pipeline is all green.
- π³π±Netherlands johnv
Nice job, adding 'keyboard back in to the title.
Regarding "JavaScript should probably be in views_ui module", I changed it into 'views module' in the summary, since you can run views without views_ui module.Did you test for both Mac and Windows? For the Form Save module β , we added 2 different key-combinations for [Ctrl-S] ('Save form').
- π¬π§United Kingdom oily Greater London
@johny #22 seems more progress. I have not tested manually yet. But the screenshots look great.
- π©π°Denmark ressa Copenhagen
I have added a task in the summary: "Check if the agreed shortcuts work in Linux, Mac and Windows."
Great point about views module vs. views_ui, thanks for updating.