Add optional parameter to Nightwatch drupalInstallModule command to enable module dependencies

Change looks good. Will admit not sure how to test but assume the committer know more of nightwatch then myself.

Sorry, I don't think I did a good job when I filed this issue. I don't think #5 is doing exactly what this issue was intended to solve. This issue was opened to remove instances where we navigate manually to install modules. These instances can be found by searching for /admin/modules within the Nightwatch directory.

Seems like we should also update https://www.drupal.org/node/3264978 → since we are changing the parameters to add a new optional parameter.

Seems like this may not work for test modules (or only for some test modules?) based on my local testing, but it's a start.

This should help a bit.

Seemed to have caused a number of errors
https://dispatcher.drupalci.org/job/drupal_patches/172509/console

Thanks @smustgrave!

This may break something else, but trying a different approach since we can't reliably filter by module machine name on /admin/modules.

The test code previously was searching for the proper name of the module, such as "FormAPI Test" and "Tabbing Manager Test" to work around this.

Feedback on this, please.

See also #3272727: Nightwatch's drupalModuleInstall() doesn't handle test modules or modules w underscores in machine name → (nice issue number!) but I think that may have missed that you can't filter by machine_name? Or maybe something changed elsewhere?

I think I've narrowed it down:

The filtering only fails when the machine name doesn't "match" with the human-readable name.

Examples:

form_test => FormAPI Test
tabbingmanager_test => Tabbing Manager Test

I will try to trace down the code to confirm this.

From what I can tell, there is an unaddressed case in the module filtering JS. As it stands, filtering by machine name only works if the module description ends with a period or other separator. The module filter does a regex search where the match must occur at the start of a word boundary, and the text it's searching just concatenates everything together.

I tracked down 🐛 Using the module filter on the module list page a module can only be found by system name if the description ends with a period Needs work which could be revived to fix that problem.

Now that 🐛 Using the module filter on the module list page a module can only be found by system name if the description ends with a period Needs work is in (thanks @lauriii!) we can go back to the filter approach.

Change looks good. Kinda new with the nightwatch stuff but looks good.

Only moving to NW for change record updates per #8

Thanks @smustgrave!

I'm actually not sure the best way to handle the change record, maybe the cleanest way would actually be to create a new change record and cross-reference that with https://www.drupal.org/node/3264978 → . I'm thinking that this change may not end up being backported so could be confusing for 9.x Nightwatch users.

Draft change record: https://www.drupal.org/node/3382659 →

Once it's published we can update the older change record to link to this one as well.

Ran tests for 11.x and all green.

New CR reads fine to me.

Committed 2257603 and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.