Schema for views style displays are missing

Created on 25 January 2022, over 2 years ago
Updated 24 May 2024, 30 days ago

Problem/Motivation

We have not schema for all bootstrap displays. It will be nice to start working on it and add config schema for all displays.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

5.5

Component

Code

Created by

🇵🇱Poland lamp5 Rzeszow

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇵🇱Poland paweldxm

    New .patch include more missing values in schema.

  • 🇨🇳China splash112

    Yes, please! But make some taxtfields "label" so they can be translated. Using the following now:

    # The 'type' should be "label" for short meta tags and "text" for ones which
    # could get longer, especially ones which use a textarea field instead of a
    # textfield.
    views.style.views_bootstrap_dropdown:
      type: views_style
      label: 'Dropdown format'
      mapping:
        button_text:
          type:  label
    
  • 🇵🇱Poland paweldxm

    I added simple labels. Additionally, I added the missing schema for table.

  • 🇩🇪Germany Anybody Porta Westfalica

    I can confirm this issue. This can be simply reproduced by using config_inspector module:

     	display.default.display_options.style.options.col_xs 	Undefined 	undefined 	Nein 	none 	missing schema 	'col_xs' ist kein unterstützter Schlüssel.
    	display.default.display_options.style.options.col_sm 	Undefined 	undefined 	Nein 	none 	missing schema 	'col_sm' ist kein unterstützter Schlüssel.
    	display.default.display_options.style.options.col_md 	Undefined 	undefined 	Nein 	col-md-6 	missing schema 	'col_md' ist kein unterstützter Schlüssel.
    	display.default.display_options.style.options.col_lg 	Undefined 	undefined 	Nein 	col-lg-4 	missing schema 	'col_lg' ist kein unterstützter Schlüssel.
    	display.default.display_options.style.options.col_xl 	Undefined 	undefined 	Nein 	none
    
  • First commit to issue fork.
  • Pipeline finished with Success
    about 2 months ago
    Total: 139s
    #166405
  • 🇩🇪Germany Grevil

    Some of these options are never actually used?

    "ViewsBootstrapGrid" for example defines loads of options in "defineOptions" but, basically, all of them are not even in use...

    Defining these to override core Grid options (like "col_class_default" or "col_class_custom") would make sense if we extend "Drupal\views\Plugin\views\style\Grid", but the "ViewsBootstrapGrid" class is extending "StylePluginBase" instead. So there seems to be no way, to actually change these options, since no UI is provided? Or am I missing something here?

  • Pipeline finished with Success
    about 2 months ago
    Total: 138s
    #166430
  • Pipeline finished with Success
    about 2 months ago
    #166455
  • Pipeline finished with Success
    about 2 months ago
    Total: 139s
    #166473
  • Status changed to Needs review about 2 months ago
  • 🇩🇪Germany Grevil

    Alright, that should be it. I adjusted the schema and a few default_values. If we want to be 100% clean, we need to provide update hooks for some views style plugins, to map their values to the new ones, in case they are using the default values. But the maintainers should decide here.

  • Status changed to Needs work about 2 months ago
  • 🇩🇪Germany Anybody Porta Westfalica
  • Status changed to Needs review about 2 months ago
  • 🇩🇪Germany Anybody Porta Westfalica

    LGTM, but a maintainer or someone else should please take a final look & test and RTBC this.

  • Pipeline finished with Success
    about 2 months ago
    Total: 226s
    #167473
  • Status changed to Fixed about 1 month ago
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024