- 🇨🇳China splash112
Yes, please! But make some taxtfields "label" so they can be translated. Using the following now:
# The 'type' should be "label" for short meta tags and "text" for ones which # could get longer, especially ones which use a textarea field instead of a # textfield. views.style.views_bootstrap_dropdown: type: views_style label: 'Dropdown format' mapping: button_text: type: label
- 🇵🇱Poland paweldxm
I added simple labels. Additionally, I added the missing schema for table.
- 🇩🇪Germany Anybody Porta Westfalica
I can confirm this issue. This can be simply reproduced by using config_inspector module:
display.default.display_options.style.options.col_xs Undefined undefined Nein none missing schema 'col_xs' ist kein unterstützter Schlüssel. display.default.display_options.style.options.col_sm Undefined undefined Nein none missing schema 'col_sm' ist kein unterstützter Schlüssel. display.default.display_options.style.options.col_md Undefined undefined Nein col-md-6 missing schema 'col_md' ist kein unterstützter Schlüssel. display.default.display_options.style.options.col_lg Undefined undefined Nein col-lg-4 missing schema 'col_lg' ist kein unterstützter Schlüssel. display.default.display_options.style.options.col_xl Undefined undefined Nein none
- First commit to issue fork.
- Merge request !12Issue #3260347 by lamp5: Schema for views style displays are missing → (Merged) created by Grevil
- 🇩🇪Germany Grevil
Some of these options are never actually used?
"ViewsBootstrapGrid" for example defines loads of options in "defineOptions" but, basically, all of them are not even in use...
Defining these to override core Grid options (like "col_class_default" or "col_class_custom") would make sense if we extend "Drupal\views\Plugin\views\style\Grid", but the "ViewsBootstrapGrid" class is extending "StylePluginBase" instead. So there seems to be no way, to actually change these options, since no UI is provided? Or am I missing something here?
- Status changed to Needs review
7 months ago 2:11pm 7 May 2024 - 🇩🇪Germany Grevil
Alright, that should be it. I adjusted the schema and a few default_values. If we want to be 100% clean, we need to provide update hooks for some views style plugins, to map their values to the new ones, in case they are using the default values. But the maintainers should decide here.
- Status changed to Needs work
7 months ago 3:36pm 7 May 2024 - Status changed to Needs review
7 months ago 1:07pm 8 May 2024 - 🇩🇪Germany Anybody Porta Westfalica
LGTM, but a maintainer or someone else should please take a final look & test and RTBC this.
- Status changed to Fixed
7 months ago 9:20pm 10 May 2024 Automatically closed - issue fixed for 2 weeks with no activity.