- 🇺🇦Ukraine Yuriy Mykhalyna
I didn't see correct patch created here, so I created one myself. This patch works for me fine. Feel free to use.
Hi all, I have created a new patch #28 for the latest version of h5p module for the compatibility of Drupal 10 compatibility.
- 🇮🇳India ravimalviya2000
Hello Team,
I have same issues getting on my drupal project.I but i tried this patches but error not solved.
- 🇨🇷Costa Rica jorgewray93
I have a problem applying the patch #30, for the structure of my project the patch can't be applied for that I take a different way creating a patch directly into the library and add the reference into my composer.json.
If you have the same issue do the next steps:
- Add the reference of your library directly in your composer
"require": {
"h5p/h5p-editor": "1.24.4"
}
- Add my patch into the patch section"patches": {
"h5p/h5p-editor": {
"PHP 8 compatibility": "patch/libary_patch.patch"
},
} - 🇺🇸United States SocialNicheGuru
Workaround:
not using the patch I added the following to my composer file"h5p/h5p-core": "1.24.4 as 1.24.2",
"h5p/h5p-editor": "1.25 as 1.24.4", - 🇨🇦Canada ryanrobinson_wlu
Patch in #32 worked for me against the new Drupal 10 dev branch.
- Status changed to RTBC
about 1 year ago 3:51pm 6 November 2023 - 🇩🇪Germany ammaletu Bonn, Germany
I just tried the current dev version of H5P with Drupal 10.1 and PHP 8.1 and got these deprecation notices. The patch from #32 fixes them.
- Status changed to Needs work
about 1 year ago 4:32pm 7 November 2023 - 🇬🇧United Kingdom catch
This needs to be fixed in https://github.com/h5p/h5p-editor-php-library if it's not already.
If the upstream library already has the fix, an MR to update the version would be good.
- 🇩🇪Germany ammaletu Bonn, Germany
It's fixed in the upstream version, see line 376 of: https://github.com/h5p/h5p-editor-php-library/blob/master/h5peditor.clas...
- Status changed to Closed: outdated
9 months ago 10:52pm 9 February 2024 - 🇨🇦Canada shaundychko
h5p/h5p-editor:1.25 supports PHP 8. Applying the patch at 🐛 Support h5p/h5p-core:1.26 and h5p/h5p-editor:1.25 Needs work updates the module to use version 1.25 of h5p-editor.