Right now the access function in both BlockUser & UnblockUser classes is identical. This is unnecessary code duplication as the two classes handle the same type of functionality.
N/A
Add a new abstract class, ChangeUserStatusBase and have both BlockUser and UnblockUser extend that. There is already precedent for this in the user module with ChangeUserStatusBase.
None
New abstract class ChangeUserStatusBase
Access function removed from BlockUser & UnblockUser
BlockUser & UnblockUser now extend ChangeUserStatusBase
None
TODO
Needs work
10.0 ✨
Last updated
A change record needs to be drafted before an issue is committed. Note: Change records used to be called change notifications.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Seems there is more discussion to be had based on #12 and #13.
If this does go through it will need a change record I believe.
I'm OP - I think we should close this one based on feedback from #12 & 13. Doesn't need to block up the issue queue :)