Add migration plugin ID to Migrate Drupal UI's log messages

I've added the migration plugin ID to the beginning of the message.

I changed this is Normal after re-reading the criteria for priorities.

Maybe could use a simple test to verify the message?

I think that tests here are not needed, this is a non-complicated change to an error message. There are no existing tests for it and adding one will be laborious with little gain.

Since this is categorized as a bug let's apply the heuristics from 🌱 [policy, no patch] Better scoping for bug fix test coverage RTBC

1. Are there clear steps to reproduce on the issue?
   
   Yes. And this can be done using the Drupal 7 test fixture.
2. Is it easy to verify via manual testing that the bug is fixed?
   
   Yes. easy for a migration test.
3. Is it a 'trivial' patch with small, easy to understand changes?
   
   Yes.
4. Is the code being changed in self-contained/@internal code that we don't expect contrib modules to interact with significantly? (plugins, controllers etc.)
   
   Yes
5. In the case that the bug is committed with test coverage then later regresses, is the impact likely to be minimal or at least no worse than leaving the bug unfixed (for example site were unlikely to be actively mitigating the bug with workarounds/patches that would be removed when it's fixed)?
   
   Yes.
6. Is the bug fix achieved without adding new, untested, code paths?
   
   Yes
7. To add test coverage, would it need an explicit 'regression' test that mainly prevents us reverting the patch rather than improving coverage in general?
   
   Yes
8. If the test coverage was deferrred to a follow-up, would it be easy for someone who didn't work on the original bug report to pick it up?
   
   Not really. There aren't many contributors to migration tests.
9. Does the issue expose a general lack of test coverage for the specific subsystem, and if so would it be better to add generic test coverage for that subsystem in a separate issue so that the test coverage can be added in a maintainable way, rather than a regression test?
   No

That is a majority of 'Yes' which means tests can be skipped. I am setting back to NR.

Removing tag too.

Gotcha

Cheers.

Updating title to show what this is doing.

Tested by running migrate_ui on a standard install. Pointing to a standard install of D7
Got
Source ID 3: Permission(s) 'access dashboard', 'access overlay', 'administer actions', 'administer fields', 'block IP addresses', 'delete revisions', 'delete terms in 1', 'edit terms in 1', 'revert revisions', 'view revisions' not found.

Applied patch

Did a fresh install, and reran and got

Migration d7_user_role: Source ID 3: Permission(s) 'access dashboard', 'access overlay', 'administer actions', 'administer fields', 'block IP addresses', 'delete revisions', 'delete terms in 1', 'edit terms in 1', 'revert revisions', 'view revisions' not found.

The last submitted patch, 6: 3259712-6.patch, failed testing. View results →

Believe this to be a random failure.

The last submitted patch, 6: 3259712-6.patch, failed testing. View results →

Random failure.

The last submitted patch, 6: 3259712-6.patch, failed testing. View results →

There was an unrelated fail. I retested and tests are passing, restoring RTBC.

1) Drupal\Tests\Component\Utility\RandomTest::testRandomMachineNamesUniqueness
RuntimeException: Unable to generate a unique random machine name

Committed 3e27116 and pushed to 11.x. Thanks!

Unfortunately not eligible for backport as there is a translatable string change.

Automatically closed - issue fixed for 2 weeks with no activity.