Html::escapeCdataElement() not adding CDATA correctly

+++ b/core/lib/Drupal/Component/Utility/Html.php
@@ -345,17 +345,16 @@ public static function serialize(\DOMDocument $document) {
+        $data = $child_node->data;
+        if (strpos($child_node->data, 'CDATA') === FALSE) {
+          $embed_prefix = "\n{$comment_start}<![CDATA[{$comment_end}\n";

Can this be !str_contains() now?

The issue summary could use an update, I'm also wondering whether the current test coverage covers the nesting case that's in the issue summary.

The existing test method \Drupal\Tests\filter\Kernel\FilterKernelTest::testHtmlCorrectorFilter is testing \Drupal\Component\Utility\Html::normalize but none of the existing or new cases call Html::normalize twice per the originally reported issue.

So I think we should add an extra test case that does that.

I think we should also open a follow up to move that test coverage out of the filter module, into the Utility component, it doesn't use any filter features.

Opened [#3352404

Added another assertion that calls normalize() twice.

This looks great, great test coverage!

Committed 16a4426 and pushed to 10.1.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.