Add Drupal 10 compatibility to Matomo reporting API

Thanks for working on this! I am not using this module any more but I had a quick look. If anyone wants to volunteer as a maintainer then please file an application :)

This still needs work:

1. Can we please keep the work limited to one merge request so that in the very little spare time I can spend on this module I don't need to waste it looking in two different places?
2. The requirements from the issue summary are not met: "Fix PHPUnit test errors and self deprecation notices"
3. The tests are failing due to composer related problems.

ressa → closed merge request !4

Thanks @pfrenssen!

@shivam_tiwari: You should be able to carry on working on other people's MR's such as MR4, as far as I understand it ... Anyway, I have closed MR4 now, so we only have one branch and MR to keep track of.

I'm sad to say that this module might have some problems porting to D10.

As far as I can tell, the module depends on pfrenssen/matomo-reporting-api, which seems to be rather stale (last commit is 5 years old).

This library depends on "guzzlehttp/guzzle": "~6.0", which worked under Drupal 9 but won't work on D10 as the core requirements for guzzle is above 7.x.

Composer won't allow to install an outdated dependency and it seems we can't count on pfrenssen/matomo-reporting-api being updated to support guzzle^7.x

I just encountered the same problem as idiaz.roncero above regarding guzzle. Is there a possibility that this could be fixed?

Composer won't allow to install an outdated dependency and it seems we can't count on pfrenssen/matomo-reporting-api being updated to support guzzle^7.x

There is a PR already started, but the remarks have not been addressed. Feel free to continue the work: https://github.com/pfrenssen/matomo-reporting-api/pull/9

Oh sorry, didn't realize the PR and I thought it was unmaintained.

No worries! It is still maintained but the projects I am involved with at the moment are not using Matomo so my focus is elsewhere. I can review MRs.

If anyone wants to help out to co-maintain the project here and/or on Github that would be very welcome!

@pfrensen if you can add me as a co-maintainer I can dedicate some time to this since we are using this module

We are using the MR from here in a custom module for now.
https://github.com/pfrenssen/matomo-reporting-api/pull/12

If any of those MR's is accepted we can move forward here too!

@miiimooo thanks for volunteering! I have added you as a co-maintainer and sent an invite to get push access on the Github library.

@johan-den-hollander if you want I can invite you to the Github repo so you can accept MRs there. Can you let me know your username on Github?

The MR fixes the D10 `core_version_requirement` and `phpunit --list-groups` but not the tests. The deprecation of the at() (https://github.com/sebastianbergmann/phpunit/issues/4297) looks tricky to fix. But maybe this is good enough as it is to go into 2.x-dev and solve the tests separately (see also #3217717: Replace usages of the at() matcher, which is deprecated → ), automated tests are broken as it stands with the old code base, not sure what the problem is there https://www.drupal.org/pift-ci-job/2776370 →

I'll wait a little while for objections to merging MR6 and splitting fixing the unit tests in case it'll break in D10 sites.

In a more daring proposal, I am thinking of moving the code from the separately pfrenssen/matomo-reporting-api into the Drupal module, mainly to reduce maintenance and complexity. I can't see that the lib is used in any other project.

In a more daring proposal, I am thinking of moving the code from the separate dependency pfrenssen/matomo-reporting-api into the Drupal module, mainly to reduce maintenance and complexity. I can't see that the lib is used in any other project.

I have no objection to this at all! And if anyone depends on the github repo they are free to fork it as well.

^^^ this commit 3b9109d7 shows what this would look like. I have taken it out from the MR6 though to sort one issue at the time

Yes! miimooo, this is exactly the route I went to get this to work as a custom module for one of our projects, I think this is a great solution!

Thanks for all the feedback.

For now I've kept the dependency on the library. Instead I have made a new release in github release 3.0.0 and changed the dependency accordingly.

I have rolled a new release of this module for Drupal 10 compatibility and this is ready for testing. To install use

composer require drupal/matomo_reporting_api:3.0.x-dev

This depends on Guzzle 7

If you need to the flexibility to depend on Guzzle 6 or 7 use

composer require drupal/matomo_reporting_api:"^2.4||3.0.x-dev"

In a more daring proposal, I am thinking of moving the code from the separate dependency pfrenssen/matomo-reporting-api into the Drupal module, mainly to reduce maintenance and complexity. I can't see that the lib is used in any other project.

This is fine for me, the separate library was made with the intention to make the code reusable in other non-Drupal PHP applications hosted by my previous employer, but it looks like it didn't get much traction there.

I will add a compatible GPL licence to the original repository so that there are no legal complications.