- First commit to issue fork.
- @nikathone opened merge request.
- Status changed to Needs review
over 1 year ago 6:59pm 28 February 2023 - π¨π¦Canada nikathone Ontario
This is an initial upgrade path. It doesn't cover views or page manager. Also people who might have implemented the approach to add an extras column for as recommended in v1 are not taken into account.
- First commit to issue fork.
- π¨π¦Canada nikathone Ontario
My last commit adds `entity_id` in the legacy schema to ensure that it stays as string. In #3270630 it was update to be an integer due to performance reasons but I would like us to keep it as string in the legacy plugin for this initial update path then open a follow up issue if the people who were using V1 face the performance problem.
- πΈπ³Senegal diaodiallo
Thanks Nia for the great work. This patch works for me as excepted for my use case, working with the legacy plugin to use my data from version one.
Howeveer I found two potential issue which worth to discuss:
1. When I enable the generic usage data and the generic usage data counter in plus the legacy plugin I have this exception:
if (!$database_schema->fieldExists($table, $counterField)) { throw new \Exception('Usage Data table ' . $table . ' schema should have a counter ' . $counterField . ' column.'); }
Line 77 in srcUsageDataDatabaseStorage.php
I think we need to test more to see how to have them all enabled without issue.2. I noticed when I visit/view a page where I have a media (I have a video) the module is adding the event_type download for the entity_type_id media row, it should be just 'view'
I think this may be an issue for the version 2 of he module.Thanks.
- First commit to issue fork.
-
andileco β
committed f4a0ac16 on 2.0.x authored by
nikathone β
Issue #3257118 by nikathone, diaodiallo, b_sharpe: 1.0 to 2.0 upgrade...
-
andileco β
committed f4a0ac16 on 2.0.x authored by
nikathone β
- Status changed to Fixed
over 1 year ago 9:00pm 10 April 2023 - πΊπΈUnited States andileco
Thank you for working on this upgrade path! Committed.
Automatically closed - issue fixed for 2 weeks with no activity.