Umami demo: Tour popup close button hover effect movement

Thanks everyone for great, thorough work here! I'm saving the issue credits, so taking some notes about who is credited and how, and advice for contributors.

1. Crediting @Gauravmahlawat for the original issue report, the original patch. and work on it since.
    

2. Creditng @lauriii for committer review.
    

3. Crediting @vulcanr and @ameymudras for coming up with a new implementation based on @lauriii's feedback.
    

4. Crediting @Satyajit1990 for the original video demonstrating the bug. I had to slow it to half speed and zoom in on the element, but I finally saw the "wiggle" in the before screenshots. Thanks for that manual testing! Next time, I would suggest cropping your video to only the affected portion of the screen so it's easier for reviews to understand and see.
   nbsp;

5. For @DeepaliJ: Thank you for reviewing this issue!

   Your before-and-after videos in #19 were helpful for me to understand the bug. Same advice as above; please crop them to only the affected portion of the screen. Thanks

   Also, regarding #22, the automated testing infrastructure tells us whether the change set still applies, so we do not need people to review that. It is also not sufficient criteria for the issue to be marked "Reviewed and Tested by the Community".

   What we do need people to review is whether the issue has a correct scope → , whether it passes the core gates → , whether the solution completely fixes the problem without introducing other problems, and whether it's the best solution we can come up with. See the patch review guide → for more information.

   When you do post a review, be sure to describe what you reviewed and how with more specific details and steps. This helps other reviewers understand why you considered the issue RTBC (and is considered for issue credit). \

   Also see the issue credit guidelines → for more information on which kinds of contributions are credited. In this case, you are still getting credit for the manual testing. 🙂
    

6. A reminder for @Kristen Pol to embed your UI changes screenshots in the issue summary. 🙂 Credited for manual testing and mentoring on the issue.
    

7. @gaurav-mathur, your comment just repeated automated testing that had been done by @DeepaliJ on the exact same patch, weeks after they did that work. That's a duplicate effort that adds noise to issues. So I am not crediting it. In the future, I suggest reading existing comments thoroughly and paying close attention to the next steps to receive credit.

I think this issue should have a final review from one of the frontend framework managers before it goes in to make sure it's the right approach, but I wanted to save time for them by taking care of the issue credit processing part of the review. 🙂

Hm I see, @Kristen Pol's screenshot was not of the correct UI element. Removing from summary. Sorry for the noise!

#21 adds an unwanted white border around the close button. A transparent border would probably work, though.

Addressed #26. Attached patch along with interdiff. please review

Would be useful to have before/after screenshots in the issue summary.

Attached before patch and after patch mov clips. please review

Thanks @Gauravvv!

The last submitted patch, 27: 3256002-27.patch, failed testing. View results →

Restoring status, unrelated failure.

Looks like I adviced against the transparent border in #11. As a second thought, it seems fine to have the transparent border appear in forced colors mode since it's a button.

Committed 2295e6e and pushed to 10.1.x. Cherry-picked to 10.0.x and 9.5.x. Thanks!