Deprecated: Required parameter $map_name in PHP 8.0

Patch #4 is an API change. I do not think this is the best solution. I think that changing this:

function openlayers_geofield_form_latlon_map($defaults = array(), $map_name) {

function openlayers_geofield_form_latlon_map($defaults = array(), $map_name = '') {

could be a more safer way to do. And also if we check the openlayers_map_load() function, where the $map_name parameter is passed, it already defaults to empty string, so it seems good to me. See: https://git.drupalcode.org/project/openlayers/-/blob/7.x-2.x/openlayers.module#L827

Updated patch #4 by addressing #10, please review it.

Thanks!

Hi,

The Geofield works for me when enabled without applying the patch against the Drupal core version of 9.5.6 and PHP 8.0.

See the attached screenshots for reference.

Thanks everyone, committed!

@roberttabigue - this issue is for 7.x-2.x version of the module (e.g. Drupal 7, not Drupal 9/10). It does not seems to affect 8.x-1.x branch.

Automatically closed - issue fixed for 2 weeks with no activity.