[PP-1] Add BookTestTrait::addNodeToBook() method and convert book tests to use it

This extension is being deprecated, see 🌱 [Meta] Tasks to deprecate Book module Active . It will be removed from core and moved to a contrib project, 📌 [11.x] [Meta] Tasks to remove Book Active .

This is now Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project → and the Extensions approved for removal → policies.

This issue may be re-opened if it can be considered critical → , If unsure, re-open the issue and ask in a comment.

Moving to contrib

Looking into 🐛 Cannot save unpublished versions of published content for users without manage book privileges Needs work now so this should only be postponed for a bit.

Based on the patch, added new addNodeToBook() helper method to BookTestTrait.php. Updated a couple of tests to use new addNodeToBook() helper method and replaced existing testing steps that produced the same result by editing the node form through separate steps.

Searched for other instances of the old submitForm() code in the test folder. Found one more similar usage in the testBookDelete() BookTest.php, but this doesn't seem to be something that is a 1:1 replacement with the new method so left it alone.

Moving to NR.

Potential testing steps:

1. In BookTest.php debug the value that is set to $edit[‘book[bid]’] in both testBook() and testBookOutline().
2. In BookTestTrait.php, debug the value that is passed in as the $book_nid.
3. The integer values should match.
4. Repeat same method with BookContentModerationTest.php, comparing $book_2->id() and $book_1_nodes[1]->id() with the values that end up getting passed to the trait.

Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.