- 🇳🇱Netherlands Lendude Amsterdam
Checked and indeed, as @longwave pointed out in #3222251: [November 8, 2021] Replace all isset constructs with the null coalescing operator → , $link_html is never used other than for setting $final_html, so we might as well just use $final_html always.
Not a bug, just a bit of cleanup really.
- Status changed to Needs review
9 months ago 9:23am 18 December 2023 - Status changed to RTBC
9 months ago 2:19pm 18 December 2023 - Status changed to Needs work
8 months ago 5:20am 30 December 2023 - 🇳🇿New Zealand quietone New Zealand
I'm triaging RTBC issues → . I read the IS and the comments. Oh, I do love a bit of cleanup!
We need to investigate what and why this is imo.
This quote is in the issue summary but I can't seem to find the investigation in this issue or in #3222251: [November 8, 2021] Replace all isset constructs with the null coalescing operator → .
For issues like this I think we should research the original intention. We should use git blame to find the issue and then read that to see how this parameter was to be used.
- Status changed to RTBC
8 months ago 1:20pm 11 January 2024 - 🇳🇱Netherlands Lendude Amsterdam
Did a check:
Investigation: See for example https://www.drupal.org/project/drupal/issues/2404603#comment-9576291 → for the test in an earlier form, where the two parameters made sense (they contained different things)
Conclusion: leftover code from previous iterations of the test that never got committed in that form and was missed in reviewAdded to the IS
- Status changed to Fixed
8 months ago 8:53pm 11 January 2024 - 🇬🇧United Kingdom catch
Committed/pushed to 11.x and cherry-picked to 10.2.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.