Prepare to switch to using (the future) Drupal 9 JSON:API endpoint - implement tests, etc.

Integrated the new logo field, which will be a separate field on projects on the new www.drupal.org D9/10 version.

This was a follow-up from ✨ Integrate GitLab Logo png to Drupal.org D7 project pages Fixed and ✨ Repository logo on projects pages styling Fixed as the repo gitlab avatar is now displayed on the project pages.

This is fantastic progress.

I think we just need to be aware that when this is promoted to the D9 endpoint, it will have the effect that many projects that have logos in the first image will lose their logos in Project Browser.

We can just define the policy here 📌 [PLAN] Where to fetch image from? Fixed and then implement the logic in this issue.

We can just fetch from the new D9 logo_url field (this is what's done right now), or add a fallback if needed.

As for the "losing" logos, taking a first image as a logo doesn't make it a logo (there are some comments about it in the linked issue). Maintainers that do worry about their logo will quickly update, and as far as I know, all the logo suggestions that we will make to the top 100 will also be made with the recommendation of adding it as logo.png to the repo.

Once users start seeing their modules showing up in project browser, they'll change logos, descriptions, etc and the advantage of the live endpoint is that the changes will show up in real-time.

In any case, I'm happy to implement whatever is decided.

@fjgarlin - Can you confirm that logo_url is only being used in the D9 version in this branch? Right now, those who have their logo as logo.png will _never_ see that appear for PB data generated from the fixture, because logo_url isn't available from the D7 API?

OR, is it and we could actually update the fixture generation code to use it? (I don't see it, say, here: https://www.drupal.org/api-d7/node.json?nid=640498 → )

Correct Chris. It's not part of the json output.
On D7, we check it (and cache it) on the fly from the gitlab avatar URL, no field required.
On D9, this is a field that checks the above URL, and populates it.

We could alter the fixture generation to check the gitlab avatar and set it as logo. That won't be a difficult one. I'm happy to address it (best on a separate issue).

I think it might also need a rebase? :)

fjgarlin → closed merge request !95

fjgarlin → closed merge request !280

It seems that markup has changed and the CSS selectors in the tests are no longer up to date. I will try to work on them.

Ok, a lot of markup changed since the test was written.
All feedback that was given at DrupalCon was addressed and all the tests have been fixed.

Ready to review again.

Reviewed the code for the JSON:API source. Seems there is an testing issue left though.

Tests are green now. I forgot to propagate the change to another part of the file. I love having tests.

Went through the last commits, changes look as expected. Only a small comment on a comment (lol), but that is probablly nothing.

RTBC if i may ;)

Woohoo! This is a major milestone step forward, and I can confirm it's not breaking anything in the UI. Renaming issue and filing follow-up.

Automatically closed - issue fixed for 2 weeks with no activity.