- 🇦🇺Australia dpi Perth, Australia
Shall we add an iframe image?
If so, please provide licensing information and ensure it is GPL compatible.
Closing MR and resetting issue as it is a different direction.
Adds an icon and install file to utilize it. Ref. https://www.drupal.org/node/2863992 →
Annnnddddd.... we can update that with the correct issue number. :/
- First commit to issue fork.
- Status changed to Needs review
about 2 years ago 3:16pm 20 October 2023 - 🇺🇸United States chrissnyder Maryland
Thank you for your work on this JSchref!. I opened a MR with your changes from the patch and added an update hook for those that already have the module installed.
- 🇺🇸United States chrissnyder Maryland
The icon in the patch/MR is from https://iconoir.com/, which I belive has an open-source MIT license. If that is not GPL-compatible, we can replace it with one of the attached icons. The attached Icons i just created myself for this project so there should not be any licensing issue with them.
- 🇫🇷France prudloff Lille
I think the MIT licence is GPL compatible : https://directory.fsf.org/wiki/License:Expat
- Status changed to Needs work
over 1 year ago 3:56pm 11 March 2024 - 🇺🇸United States smustgrave
Tried testing the MR but the icon is still missing. Tried applying the MR before installing the module.
- Status changed to RTBC
over 1 year ago 4:12pm 11 March 2024 - 🇺🇸United States smustgrave
Eh maybe it's an issue with getting the image via applying as a patch. I downloaded the image directly from the MR and copied that over to my files directory and works now.
- 🇷🇪Réunion Martygraphie Saint-Denis (Réunion)
Hello,
I confirm @smustgrave's last comment.
I can't apply the patch in MR #6, but if I retrieve the image and add it manually to the folder it works too.I prefer the iframe.png image in comment #12, which is more explicit than the image in MR.
- Status changed to Needs work
over 1 year ago 2:16am 26 August 2024 - 🇦🇺Australia dpi Perth, Australia
Thanks everyone for continuing to push this along.
Theres some code gripes, for which I'm happy to address myself.
My major concern (cue bikeshedding) is the icon as proposed doesn't really capture the concept of iframe.
It is much closer to something that would represent a popup, since it seems to have the Mac-like three dots a window would have. But as we know, iframes do not have a window-border.
Some thoughts for an iframe: box with address bar or scroll bar. Use some kind of HTML-concept as the box concents, like a _generic_ tag:
</>There's a variety of concepts, alongside the one proposed, found when using search on icon websites/image search.
Lets try to keep rounded-corners/stroke-width similar to that found in the default Drupal/CKE icons. Mono/uncolored is great.
- 🇺🇸United States smustgrave
I've asked one of our UX designers for an image as we are trying to use this on a new project.
