Do slightly less work in \Drupal\Core\EventSubscriber\ActiveLinkResponseFilter::setLinkActiveClass()

Created on 22 September 2021, about 3 years ago
Updated 30 January 2023, almost 2 years ago

Problem/Motivation

We loop around a lot in \Drupal\Core\EventSubscriber\ActiveLinkResponseFilter::setLinkActiveClass() looking for end tags. Any link which contains data-drupal-link-system-path="<front>" is examined. We start looking for the end tag from the "d" of the data but we know it's not going to be the next few characters because of the match we've already done.

Proposed resolution

Determine where to start looking for the end tag before looping.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

N/a

πŸ“Œ Task
Status

Needs work

Version

10.1 ✨

Component
BaseΒ  β†’

Last updated about 1 hour ago

Created by

πŸ‡¬πŸ‡§United Kingdom alexpott πŸ‡ͺπŸ‡ΊπŸŒ

Live updates comments and jobs are added and updated live.
  • needs profiling

    It may affect performance, and thus requires in-depth technical reviews and profiling.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • The Needs Review Queue Bot β†’ tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

    Consult the Drupal Contributor Guide β†’ to find step-by-step guides for working with issues.

Production build 0.71.5 2024